Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1196041: Ignore default credentials in GCS client #1656

Merged
merged 4 commits into from
Mar 12, 2024
Merged

SNOW-1196041: Ignore default credentials in GCS client #1656

merged 4 commits into from
Mar 12, 2024

Conversation

sfc-gh-dprzybysz
Copy link
Contributor

Overview

SNOW-1196041

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:

@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner March 4, 2024 07:28
sfc-gh-pmotacki
sfc-gh-pmotacki approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sfc-gh-igarish
sfc-gh-igarish approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-1196041-ignore-default-credentials-in-gcs-client branch from 589dec9 to 5a8f204 Compare March 7, 2024 07:09
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-1196041-ignore-default-credentials-in-gcs-client branch from 5a8f204 to 0863c1c Compare March 7, 2024 07:43
@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 730fbbf into master Mar 12, 2024
36 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-1196041-ignore-default-credentials-in-gcs-client branch March 12, 2024 06:04
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-dprzybysz @sfc-gh-igarish @sfc-gh-pmotacki