Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1958601: Fix NPE when cache folder is inaccessible #2108

Merged
merged 5 commits into from
Mar 14, 2025
Merged

SNOW-1958601: Fix NPE when cache folder is inaccessible #2108

merged 5 commits into from
Mar 14, 2025

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

@sfc-gh-pbulawa sfc-gh-pbulawa commented Mar 4, 2025 •
edited
Loading

Overview

SNOW-1958601

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • [] New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner March 4, 2025 13:35
@sfc-gh-pbulawa sfc-gh-pbulawa changed the title SNOW-1958601-cache-file-check SNOW-1958601: Fix NPE when cache folder is inaccessible Mar 4, 2025
@sfc-gh-pbulawa sfc-gh-pbulawa force-pushed the SNOW-1958601-cache-file-check branch from 8b8fdcc to 5d734f7 Compare March 4, 2025 13:38
@sfc-gh-pbulawa sfc-gh-pbulawa mentioned this pull request Mar 4, 2025
Open
sfc-gh-pmotacki
sfc-gh-pmotacki requested changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please think about places I mentioned in previous comment?

@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1958601-cache-file-check branch from 265995e to e8f6ed6 Compare March 14, 2025 08:31
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit 464540d into master Mar 14, 2025
138 of 142 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-1958601-cache-file-check branch March 14, 2025 09:55
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

@sfc-gh-mkubik sfc-gh-mkubik sfc-gh-mkubik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-pbulawa @sfc-gh-pmotacki @sfc-gh-pfus @sfc-gh-mkubik