[#589] Upgrading netty to enable JDK17 #668
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #589, may fix #484 by upgrading Netty (and json-smart)
External contributors - please answer these questions before submitting a pull request. Thanks!
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR adressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-755767: snowflake-jdbc driver fails with JDK >= 16 #589 which relates directly to SNOW-340077: UnsupportedOperationException sun.misc.Unsafe or java.nio.DirectByteBuffer when running on JDK16 #484, both of which are the result of Project Jigsaw encapsulation.
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Netty (
netty-common
) is ultimately at fault for the JDK17 illegal access reported in both tickets. Arrow depends on that machinery by simple dependency.snowflake-jdbc
pulls in and shades both arrow and netty components. This makes it impossible for users ofsnowflake-jdbc
to directly override the packaged dependency and run a newer (fixed) netty.Per the netty maintainers 4.1.52+ has fixes for JDK17 access restrictions. In my testing rolling a snowflake-jdbc jar which forces netty-* to 4.1.72.Final (latest) resolves these issues.
Pre-review checklist