V1.8.3 release #521
Merged
V1.8.3 release #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sfc-gh-tzhang
commented
Dec 22, 2022
sfc-gh-tzhang
commented
- Upgrade to 1.8.3 from 1.8.2 that includes some fixes for schematization
- Upgrade the SDK version to beta.7 for confluent
Co-authored-by: Toby Zhang <[email protected]>
…nowflake-kafka-connector into schema-mapping-new
sfc-gh-tzhang
requested review from
sfc-gh-japatel,
sfc-gh-tjones and
sfc-gh-rcheng
as code owners
| @@ -368,7 +368,7 @@ | |||
| <dependency> | |||
| <groupId>net.snowflake</groupId> | |||
| <artifactId>snowflake-ingest-sdk</artifactId> | |||
| <version>1.0.2-beta.4</version> | |||
| <version>1.0.2-beta.7</version> | |||
There was a problem hiding this comment.
was there some perf regression in 1.0.2-beta.5? I saw some jira from @sfc-gh-lsembera
There was a problem hiding this comment.
Yes, there was a perf regression relating to timestamps.
There was a problem hiding this comment.
Yes, but beta.5-beta.7 also contain a bunch of corruption/wrong result fixes, so I think it would be good to upgrade since correctness is more important than performance (for example: https://snowflakecomputing.atlassian.net/browse/SNOW-718273 shows we're hitting it in SFCTEST0)
sfc-gh-japatel
approved these changes
Dec 22, 2022
sfc-gh-tjones
approved these changes
Dec 23, 2022
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
==========================================
+ Coverage 87.43% 87.45% +0.02%
==========================================
Files 47 47
Lines 4169 4169
Branches 453 453
==========================================
+ Hits 3645 3646 +1
+ Misses 350 349 -1
Partials 174 174
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.