fix(jruby): create_element should not set the doc's default ns #3463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ns should be set explicitly or when the node is parented. Fixes #3457
flavorjones
force-pushed
the
flavorjones-3457-jruby-ns-create-element
branch
from
8a4033e to
ad5960d
Compare
| } | ||
| element = document.createElementNS(namespace_uri, node_name); | ||
|
|
||
| element = document.createElementNS(null, node_name); | ||
| setNode(context.runtime, element); |
There was a problem hiding this comment.
Can remove:
Element element;
String node_name = rubyStringToString(name);
Then do:
setNode(context.runtime, document.createElementNS(null, node_name));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
The namespace should be nil by default, and must be set explicitly or when the node is parented.
Fixes #3457
Have you included adequate test coverage?
Yes.
Does this change affect the behavior of either the C or the Java implementations?
Just the Java implementation, to match CRuby behavior.