Detect Kingbase JDBC driver #44710

zbw1231 · 2025-03-13T11:07:46Z

I add support for Kingabse（A new database）for v3.4.0.

wilkinsona · 2025-03-13T11:19:15Z

gradle.properties

@@ -1,4 +1,4 @@
-version=3.4.0-SNAPSHOT


3.4.0 was released last year and cannot be changed. Please revert.

nosan · 2025-03-13T17:49:34Z

Hi @zbw1231

I add support for Kingbase（A new database）

Typically, such changes are classified as enhancements, which means they would be
merged into the main branch and included in the upcoming 3.5.X release.

Unfortunately, your PR cannot be merged in its current state. It needs some updates to be considered as a potential candidate for merging:

Your branch should be rebased on top of the main branch
Your PR does not include any tests. It would be helpful to add some tests to DatabaseDriverTests.java to verify your changes.
I also noticed that you did not use the spring-javaformat formatter, so there are likely checkstyle errors.
Your commit must be signed to pass the DCO check.

I highly recommend reading CONTRIBUTING.adoc as it contains very useful information for contributors.

Additionally, the changes in your PR are very similar to this, so feel free to use it as a potential guide.

nosan · 2025-03-13T17:53:10Z

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/jdbc/DatabaseDriver.java

+	/**
+	 * Kingbase.
+	 */
+	KINGBASE("KingbaseES","com.kingbase8.Driver","com.kingbase8.xa.KBXADataSource","SELECT 1"),


I think you also need to add URL prefix.

@Override protected Collection<String> getUrlPrefixes() { return Collections.singleton("kingbase8"); }

Thanks for your advice,I added test and URL prefix for kingbase like the example you provided.Please review.

Signed-off-by: zbw1231 <[email protected]>

nosan

Thank you, @zbw1231

I've left some comments for you consideration.

nosan · 2025-03-16T10:13:20Z

gradle.properties

@@ -1,4 +1,4 @@
-version=3.5.0-SNAPSHOT
+version=3.4.0


Please revert.

nosan · 2025-03-16T10:13:37Z

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/jdbc/DatabaseDriver.java

@@ -83,6 +83,19 @@ public enum DatabaseDriver {
 	 */
 	POSTGRESQL("PostgreSQL", "org.postgresql.Driver", "org.postgresql.xa.PGXADataSource", "SELECT 1"),

+	/**
+	 * Kingbase.
+	 * @since 3.4.0


@since 3.5.0

nosan · 2025-03-16T10:14:02Z

...oot-project/spring-boot/src/test/java/org/springframework/boot/jdbc/DatabaseDriverTests.java

@@ -99,6 +100,8 @@ void databaseJdbcUrlLookups() {
 			.isEqualTo(DatabaseDriver.ORACLE);
 		assertThat(DatabaseDriver.fromJdbcUrl("jdbc:postgresql://127.0.0.1:5432/sample"))
 			.isEqualTo(DatabaseDriver.POSTGRESQL);
+		assertThat(DatabaseDriver.fromJdbcUrl("jdbc:kingbase8://localhost:54321/test"))


This test fails.

Please run ./gradlew build to verify your changes

nosan · 2025-03-16T10:44:02Z

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/jdbc/DatabaseDriver.java

+	 * Kingbase.
+	 * @since 3.4.0
+	 */
+	KINGBASE("KingbaseES","com.kingbase8.Driver","com.kingbase8.xa.KBXADataSource","SELECT 1") {


There is still an issue with the formatting. Please refer to the Spring Boot Contributing Guidelines.

Please use ./gradlew format to reformat your code.

nosan · 2025-03-16T10:45:03Z

...oot-project/spring-boot/src/test/java/org/springframework/boot/jdbc/DatabaseDriverTests.java

@@ -72,6 +72,7 @@ void databaseProductNameLookups() {
 		assertThat(DatabaseDriver.fromProductName("MariaDB")).isEqualTo(DatabaseDriver.MARIADB);
 		assertThat(DatabaseDriver.fromProductName("Oracle")).isEqualTo(DatabaseDriver.ORACLE);
 		assertThat(DatabaseDriver.fromProductName("PostgreSQL")).isEqualTo(DatabaseDriver.POSTGRESQL);
+		assertThat(DatabaseDriver.fromProductName("KingbaseES")).isEqualTo(DatabaseDriver.KingbaseES);


Compile error:

/Users/dmytronosan/IdeaProjects/spring-boot/spring-boot-project/spring-boot/src/test/java/org/springframework/boot/jdbc/DatabaseDriverTests.java:75: error: cannot find symbol
assertThat(DatabaseDriver.fromProductName("KingbaseES")).isEqualTo(DatabaseDriver.KingbaseES);
^
symbol: variable KingbaseES
location: class DatabaseDriver

Please run ./gradlew build to ensure that your changes do not break the build.

spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 13, 2025

wilkinsona reviewed Mar 13, 2025

View reviewed changes

nosan reviewed Mar 13, 2025

View reviewed changes

snicoll changed the title ~~Spring boot 3.4.0 changes~~ Detect Kingbase JDBC driver Mar 14, 2025

snicoll added the status: waiting-for-feedback We need additional information before we can continue label Mar 14, 2025

zbw1231 force-pushed the spring-boot-3.4.0-changes branch from 1896a69 to f7bb14f Compare March 16, 2025 07:56

wilkinsona and others added 3 commits March 16, 2025 17:53

Release v3.4.0

eb0a844

Signed-off-by: zbw1231 <[email protected]>

add support for kingbase

d06ed24

Signed-off-by: zbw1231 <[email protected]>

Add support for kingabse

631643d

Signed-off-by: zbw1231 <[email protected]>

zbw1231 force-pushed the spring-boot-3.4.0-changes branch from 027573f to 631643d Compare March 16, 2025 09:53

nosan reviewed Mar 16, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Detect Kingbase JDBC driver #44710

Detect Kingbase JDBC driver #44710

zbw1231 commented Mar 13, 2025

wilkinsona Mar 13, 2025

nosan commented Mar 13, 2025 •

edited

Loading

nosan Mar 13, 2025

zbw1231 Mar 16, 2025

nosan left a comment

nosan Mar 16, 2025

nosan Mar 16, 2025

nosan Mar 16, 2025 •

edited

Loading

nosan Mar 16, 2025

nosan Mar 16, 2025 •

edited

Loading

		@@ -1,4 +1,4 @@
		version=3.5.0-SNAPSHOT
		version=3.4.0

Detect Kingbase JDBC driver #44710

Are you sure you want to change the base?

Detect Kingbase JDBC driver #44710

Conversation

zbw1231 commented Mar 13, 2025

wilkinsona Mar 13, 2025

Choose a reason for hiding this comment

nosan commented Mar 13, 2025 • edited Loading

nosan Mar 13, 2025

Choose a reason for hiding this comment

zbw1231 Mar 16, 2025

Choose a reason for hiding this comment

nosan left a comment

Choose a reason for hiding this comment

nosan Mar 16, 2025

Choose a reason for hiding this comment

nosan Mar 16, 2025

Choose a reason for hiding this comment

nosan Mar 16, 2025 • edited Loading

Choose a reason for hiding this comment

nosan Mar 16, 2025

Choose a reason for hiding this comment

nosan Mar 16, 2025 • edited Loading

Choose a reason for hiding this comment

nosan commented Mar 13, 2025 •

edited

Loading

nosan Mar 16, 2025 •

edited

Loading

nosan Mar 16, 2025 •

edited

Loading