-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed missing deletion of the migration znode on KRaft migration rollback #11271
Merged
ppatierno
merged 7 commits into
strimzi:release-0.45.x
from
ppatierno:fix-rollback-migration-znode-deletion
Mar 20, 2025
Merged
Fixed missing deletion of the migration znode on KRaft migration rollback #11271
ppatierno
merged 7 commits into
strimzi:release-0.45.x
from
ppatierno:fix-rollback-migration-znode-deletion
Mar 20, 2025
+68
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…back Signed-off-by: Paolo Patierno <[email protected]>
/azp run migration |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Paolo Patierno <[email protected]>
/azp run migration |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Paolo Patierno <[email protected]>
im-konge
approved these changes
Mar 19, 2025
Signed-off-by: Paolo Patierno <[email protected]>
fvaleri
reviewed
Mar 19, 2025
...perator/src/main/java/io/strimzi/operator/cluster/operator/assembly/KRaftMigrationUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Paolo Patierno <[email protected]>
fvaleri
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.Thanks.
Signed-off-by: Paolo Patierno <[email protected]>
@PaulRMellor are you ok with latest changes we agreed offline? |
katheris
approved these changes
Mar 20, 2025
PaulRMellor
approved these changes
Mar 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Thanks, Paolo
Signed-off-by: Paolo Patierno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR fixes #11262 by adding the deletion of the
/migration
znode when rolling back from a KRaft migration.Checklist