Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing deletion of the migration znode on KRaft migration rollback #11271

Conversation

ppatierno
Copy link
Member

@ppatierno ppatierno commented Mar 17, 2025

Type of change

  • Bugfix

Description

This PR fixes #11262 by adding the deletion of the /migration znode when rolling back from a KRaft migration.

Checklist

  • Make sure all tests pass
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md

@ppatierno ppatierno added this to the 0.45.1 milestone Mar 17, 2025
@ppatierno
Copy link
Member Author

/azp run migration

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ppatierno
Copy link
Member Author

/azp run migration

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ppatierno
Copy link
Member Author

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Paolo Patierno <[email protected]>
Signed-off-by: Paolo Patierno <[email protected]>
Copy link
Contributor

@fvaleri fvaleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.Thanks.

@ppatierno
Copy link
Member Author

@PaulRMellor are you ok with latest changes we agreed offline?

Copy link
Contributor

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks, Paolo

Signed-off-by: Paolo Patierno <[email protected]>
@ppatierno ppatierno merged commit f51018e into strimzi:release-0.45.x Mar 20, 2025
11 checks passed
@ppatierno ppatierno deleted the fix-rollback-migration-znode-deletion branch March 20, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants