Skip to content
This repository was archived by the owner on Apr 17, 2024. It is now read-only.

Commit cebe5e7

Browse files
morambrocopybara-github
authored andcommitted
Add missing gRPC deps
Also upgrade protobuf to 25.3 in java_src/ PiperOrigin-RevId: 615364375
1 parent be58924 commit cebe5e7

File tree

4 files changed

+56
-12
lines changed

4 files changed

+56
-12
lines changed

java_src/WORKSPACE

+16-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
workspace(name = "tink_java")
22

3-
load("@tink_java//:tink_java_deps.bzl", "tink_java_deps", "TINK_MAVEN_ARTIFACTS")
3+
load("@tink_java//:tink_java_deps.bzl", "TINK_MAVEN_ARTIFACTS", "tink_java_deps")
44

55
tink_java_deps()
66

@@ -9,9 +9,23 @@ load("@tink_java//:tink_java_deps_init.bzl", "tink_java_deps_init")
99
tink_java_deps_init()
1010

1111
load("@rules_jvm_external//:defs.bzl", "maven_install")
12+
load("@rules_jvm_external//:specs.bzl", "maven")
1213

1314
maven_install(
14-
artifacts = TINK_MAVEN_ARTIFACTS,
15+
artifacts = TINK_MAVEN_ARTIFACTS + [
16+
# This is needed to add grpc-core while removing a circular dependency
17+
# between grpc-core and grpc-util.
18+
#
19+
# See https://github.com/grpc/grpc-java/issues/10576.
20+
maven.artifact(
21+
artifact = "grpc-core",
22+
exclusions = [
23+
"io.grpc:grpc-util",
24+
],
25+
group = "io.grpc",
26+
version = "1.59.1",
27+
),
28+
],
1529
repositories = [
1630
"https://maven.google.com",
1731
"https://repo1.maven.org/maven2",

java_src/examples/WORKSPACE

+16-3
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ local_repository(
2828

2929
# Load Tink dependencies.
3030

31-
load("@tink_java//:tink_java_deps.bzl", "tink_java_deps", "TINK_MAVEN_ARTIFACTS")
31+
load("@tink_java//:tink_java_deps.bzl", "TINK_MAVEN_ARTIFACTS", "tink_java_deps")
3232

3333
tink_java_deps()
3434

@@ -37,11 +37,24 @@ load("@tink_java//:tink_java_deps_init.bzl", "tink_java_deps_init")
3737
tink_java_deps_init()
3838

3939
load("@rules_jvm_external//:defs.bzl", "maven_install")
40+
load("@rules_jvm_external//:specs.bzl", "maven")
4041

4142
maven_install(
4243
artifacts = TINK_MAVEN_ARTIFACTS + [
43-
"args4j:args4j:2.33",
44-
"com.google.cloud:google-cloud-storage:2.28.0",
44+
"args4j:args4j:2.33",
45+
"com.google.cloud:google-cloud-storage:2.28.0",
46+
# This is needed to add grpc-core while removing a circular dependency
47+
# between grpc-core and grpc-util.
48+
#
49+
# See https://github.com/grpc/grpc-java/issues/10576.
50+
maven.artifact(
51+
artifact = "grpc-core",
52+
exclusions = [
53+
"io.grpc:grpc-util",
54+
],
55+
group = "io.grpc",
56+
version = "1.59.1",
57+
),
4558
],
4659
repositories = [
4760
"https://maven.google.com",

java_src/tink_java_deps.bzl

+10-4
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive", "http_file")
44

5+
_GRPC_VERSION = "1.59.1"
6+
57
TINK_MAVEN_ARTIFACTS = [
68
"com.google.protobuf:protobuf-java:3.25.1",
79
"com.google.protobuf:protobuf-javalite:3.25.1",
@@ -26,6 +28,10 @@ TINK_MAVEN_ARTIFACTS = [
2628
"com.google.oauth-client:google-oauth-client:1.34.1",
2729
"com.google.truth:truth:0.44",
2830
"io.github.jopenlibs:vault-java-driver:5.4.0",
31+
"io.grpc:grpc-api:%s" % _GRPC_VERSION,
32+
"io.grpc:grpc-inprocess:%s" % _GRPC_VERSION,
33+
"io.grpc:grpc-stub:%s" % _GRPC_VERSION,
34+
"io.grpc:grpc-testing:%s" % _GRPC_VERSION,
2935
"junit:junit:4.13.2",
3036
"org.conscrypt:conscrypt-openjdk-uber:2.5.2",
3137
"org.ow2.asm:asm:7.0",
@@ -67,12 +73,12 @@ def tink_java_deps():
6773
# * @com_google_protobuf//:java_toolchain
6874
# This statement defines the @com_google_protobuf repo.
6975
if not native.existing_rule("com_google_protobuf"):
70-
# Release X.21.9 from 2022-10-26.
76+
# Release from Feb 16, 2024.
7177
http_archive(
7278
name = "com_google_protobuf",
73-
strip_prefix = "protobuf-21.9",
74-
urls = ["https://github.com/protocolbuffers/protobuf/archive/refs/tags/v21.9.zip"],
75-
sha256 = "5babb8571f1cceafe0c18e13ddb3be556e87e12ceea3463d6b0d0064e6cc1ac3",
79+
strip_prefix = "protobuf-25.3",
80+
urls = ["https://github.com/protocolbuffers/protobuf/archive/refs/tags/v25.3.zip"],
81+
sha256 = "5156b22536feaa88cf95503153a6b2cd67cc80f20f1218f154b84a12c288a220",
7682
)
7783

7884
# -------------------------------------------------------------------------

tools/WORKSPACE

+14-3
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
11
workspace(name = "tools")
22

3-
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
4-
53
local_repository(
64
name = "tink_java",
75
path = "../java_src",
86
)
97

10-
load("@tink_java//:tink_java_deps.bzl", "tink_java_deps", "TINK_MAVEN_ARTIFACTS")
8+
load("@tink_java//:tink_java_deps.bzl", "TINK_MAVEN_ARTIFACTS", "tink_java_deps")
119

1210
tink_java_deps()
1311

@@ -16,9 +14,22 @@ load("@tink_java//:tink_java_deps_init.bzl", "tink_java_deps_init")
1614
tink_java_deps_init()
1715

1816
load("@rules_jvm_external//:defs.bzl", "maven_install")
17+
load("@rules_jvm_external//:specs.bzl", "maven")
1918

2019
maven_install(
2120
artifacts = TINK_MAVEN_ARTIFACTS + [
21+
# This is needed to add grpc-core while removing a circular dependency
22+
# between grpc-core and grpc-util.
23+
#
24+
# See https://github.com/grpc/grpc-java/issues/10576.
25+
maven.artifact(
26+
artifact = "grpc-core",
27+
exclusions = [
28+
"io.grpc:grpc-util",
29+
],
30+
group = "io.grpc",
31+
version = "1.59.1",
32+
),
2233
"args4j:args4j:2.33",
2334
],
2435
repositories = [

0 commit comments

Comments
 (0)