Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Bool type for ClickHouse connector #25130

Open
formorter opened this issue Feb 25, 2025 · 5 comments · May be fixed by #25337
Open

Add support for Bool type for ClickHouse connector #25130

formorter opened this issue Feb 25, 2025 · 5 comments · May be fixed by #25337
Labels
good first issue Good for newcomers

Comments

@formorter
Copy link

Hello there! Currently, the ClickHouse connector does not support the Bool type and cant resolve columns with this type from ClickHouse, as noted in the type mapping documentation.
It would be great if the ClickHouse connector could support Bool type
@ebyhr ebyhr added the good first issue Good for newcomers label Feb 25, 2025
@sanjyot242
Copy link

sanjyot242 commented Mar 4, 2025 •
edited
Loading

I'm interested in contributing to this , please assign me . @ebyhr Could you share some tips or key points I should keep in mind for this particular tasks?

@ebyhr
Copy link
Member

ebyhr commented Mar 5, 2025

@sanjyot242 You don't need to get the assignment, please feel free to send the PR. You will need to fix ClickHouseClient and BaseClickHouseTypeMapping classes. Also, I recommend submitting CLA beforehand since the process takes a few days.

@sanjyot242
Copy link

Will do , Thanks !

@AyushJagaty
Copy link

@ebyhr I'm interested in contributing to this.

@ashish135906
Copy link

Any updates here? We are also facing the same issue

@codeDing18 codeDing18 linked a pull request Mar 18, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for Bool type for ClickHouse connector codeDing18/trino
5 participants
@ebyhr @sanjyot242 @formorter @ashish135906 @AyushJagaty