Add support for Bool type for ClickHouse connector #25337
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
@cla-bot check |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
The cla-bot has been summoned, and re-checked this pull request! |
| @@ -638,6 +639,8 @@ public Optional<ColumnMapping> toColumnMapping(ConnectorSession session, Connect | |||
| ClickHouseColumn column = ClickHouseColumn.of("", jdbcTypeName); | |||
| ClickHouseDataType columnDataType = column.getDataType(); | |||
| switch (columnDataType) { | |||
| case Bool: | |||
| return Optional.of(booleanColumnMapping()); | |||
There was a problem hiding this comment.
Please update the following comment in toWriteMapping method:
// ClickHouse is no separate type for boolean values. Use UInt8 type, restricted to the values 0 or 1.
There was a problem hiding this comment.
Which ClickHouse version introduced Bool type?
There was a problem hiding this comment.
Which ClickHouse version introduced Bool type?
Support for Bool data type after v21.12. https://clickhouse.com/docs/whats-new/changelog/2021#clickhouse-release-212
There was a problem hiding this comment.
Please update the following comment in
toWriteMappingmethod:// ClickHouse is no separate type for boolean values. Use UInt8 type, restricted to the values 0 or 1.
ok. I have revised the comment.
// Type bool is internally stored as UInt8. Possible values are true (1), false (0).
There was a problem hiding this comment.
Also, what is the oldest supported version of ClickHouse? I'm asking this question because we also want to change the write mapping if all supported versions support boolean type.
There was a problem hiding this comment.
The oldest supported version of ClickHouse is v21.12. This version was released on 2021-12-15
plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java
Show resolved
Hide resolved
plugin/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/BaseClickHouseTypeMapping.java
Outdated
Show resolved
Hide resolved
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
@codeDing18 Did you submit CLA? |
|
@cla-bot check |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@codeDing18 |
I sent the CLA email 7 days ago. email is csding18@qq.com. |
|
@codeDing18 Note that CLA is processed every 2 weeks. |
If the email is processed, will I receive a message notification? |
Description
fix #25130
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: