Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default arch in CI #135

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Use default arch in CI #135

merged 5 commits into from
Dec 2, 2024

Conversation

JoshuaLampert
Copy link
Member

There are warnings (e.g., https://github.com/trixi-framework/P4est.jl/actions/runs/12108765313) in the CI runs because we request x64 on a macOS runner with arm64. I propose to simply use the default architecture, i.e. to remove the arch argument.

@JoshuaLampert JoshuaLampert requested a review from ranocha December 2, 2024 17:48
@JoshuaLampert
Copy link
Member Author

Oh, macos-latest (macos-14) doesn't run on Julia v1.6. What's the best way to proceed?

  1. Use macos-13
  2. Exclude macos-latest for Julia v1.6 (and include macos-13 for Julia v1.6)
  3. Drop support for Julia v1.6 and Julia v1.7
  4. Something else

See also https://discourse.julialang.org/t/how-to-fix-github-actions-ci-failures-with-julia-1-6-or-1-7-on-macos-latest-and-macos-14/117019. I would prefer option 2, but have no strong opinion.

@ranocha
Copy link
Member

ranocha commented Dec 2, 2024

Option 2 sounds good to me 👍

@ranocha
Copy link
Member

ranocha commented Dec 2, 2024

@JoshuaLampert
Copy link
Member Author

Should be fixed now.

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.51%. Comparing base (c8d680f) to head (468f7be).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   17.51%   17.51%           
=======================================
  Files           3        3           
  Lines        1422     1422           
=======================================
  Hits          249      249           
  Misses       1173     1173           
Flag Coverage Δ
unittests 17.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaLampert JoshuaLampert merged commit 505a16b into main Dec 2, 2024
17 checks passed
@JoshuaLampert JoshuaLampert deleted the arch-ci branch December 2, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants