-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use default arch
in CI
#135
Conversation
Oh, macos-latest (macos-14) doesn't run on Julia v1.6. What's the best way to proceed?
See also https://discourse.julialang.org/t/how-to-fix-github-actions-ci-failures-with-julia-1-6-or-1-7-on-macos-latest-and-macos-14/117019. I would prefer option 2, but have no strong opinion. |
Option 2 sounds good to me 👍 |
Should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
=======================================
Coverage 17.51% 17.51%
=======================================
Files 3 3
Lines 1422 1422
=======================================
Hits 249 249
Misses 1173 1173
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There are warnings (e.g., https://github.com/trixi-framework/P4est.jl/actions/runs/12108765313) in the CI runs because we request x64 on a macOS runner with arm64. I propose to simply use the default architecture, i.e. to remove the
arch
argument.