Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moodle coding style fixes (without Github actions) #731

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Moodle coding style fixes (without Github actions) #731

wants to merge 14 commits into from

Conversation

lucaboesch
Copy link
Contributor

Referring to #728 and the discussion there.

@lucaboesch lucaboesch mentioned this pull request Jul 29, 2024
Open
@lucaboesch lucaboesch changed the title Codingstyle fixes (without Github actions) Moodle coding style fixes (without Github actions) Jul 30, 2024
@lucaboesch lucaboesch force-pushed the codingstylefixeswithoutgithubactions branch from c421586 to d303c01 Compare August 5, 2024 22:11
@lucaboesch lucaboesch force-pushed the codingstylefixeswithoutgithubactions branch 2 times, most recently from a3ed9e0 to 32bd268 Compare August 14, 2024 12:42
@lucaboesch
Copy link
Contributor Author

Rebased to current develop branch

@lucaboesch lucaboesch force-pushed the codingstylefixeswithoutgithubactions branch 3 times, most recently from 0beaece to 471b675 Compare August 15, 2024 07:25
@lucaboesch lucaboesch force-pushed the codingstylefixeswithoutgithubactions branch from 471b675 to 0ba75e9 Compare December 5, 2024 15:24
@snyk-io Snyk.io
Copy link

snyk-io bot commented Dec 5, 2024 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

✅ code/snyk check is complete. No issues have been found. (View Details)

jack-tii and others added 12 commits December 5, 2024 15:53
@lucaboesch lucaboesch force-pushed the codingstylefixeswithoutgithubactions branch 6 times, most recently from 8fbdc5d to 0c8494f Compare December 20, 2024 14:39
@lucaboesch lucaboesch force-pushed the codingstylefixeswithoutgithubactions branch 3 times, most recently from ccaee3d to f907128 Compare December 20, 2024 15:03
@lucaboesch
Copy link
Contributor Author

I've updated the coding style issues again, and it would be great if they could be merged.

jack-tii
jack-tii requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@jack-tii jack-tii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your continued support, this was a pretty big undertaking! There are 2 minor things I've commented on, if we can get some clarification and one minor change I'm happy to merge this now that we're at the start of our next release cycle

@lucaboesch lucaboesch force-pushed the codingstylefixeswithoutgithubactions branch 3 times, most recently from 5878564 to ea5ac90 Compare December 21, 2024 10:56
@lucaboesch lucaboesch force-pushed the codingstylefixeswithoutgithubactions branch from ea5ac90 to 8886434 Compare December 21, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-tii jack-tii jack-tii requested changes

Assignees
No one assigned
Labels
investigating
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucaboesch @jack-tii