Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: UC_HOOK_MEM_READ only triggered once on Arm64 Host machine. #1935

Closed
wants to merge 6 commits into from

Conversation

saicao
Copy link
Contributor

@saicao saicao commented Apr 12, 2024

Fix UC_HOOK_MEM_READ only triggered once on Arm64 Host machine.
add simple test for that.
#1908.

@saicao
Copy link
Contributor Author

saicao commented Apr 12, 2024

ppc64le host have same problem with mem hook.
It fail my unit tests. want to me remove the unit test I added?

@wtdcode
Copy link
Member

wtdcode commented Apr 12, 2024

ppc64le host have same problem with mem hook. It fail my unit tests. want to me remove the unit test I added?

You can disable tests for ppc64 by using defines as I did somethere.

@Gavin0210
Copy link

I try it in android arm64,but not work

@droe
Copy link
Contributor

droe commented Sep 6, 2024

fwiw, this patch, applied on top of d4b9248, addresses this (hugely annoying) issue for me.

What is needed to get a fix merged?

@glennsec glennsec mentioned this pull request Oct 9, 2024
@wtdcode
Copy link
Member

wtdcode commented Jan 4, 2025

I have to close this in favor of #2028.

@saicao I notice you have a few additional fixes not merged yet.

1d3bfc4 is fixed already.
2d87f9c seems related to #2053
d01904d seems too dirty.

Could you illustrate how to reproduce the bugs you met?

@wtdcode wtdcode closed this Jan 4, 2025
@wtdcode wtdcode reopened this Jan 4, 2025
@wtdcode
Copy link
Member

wtdcode commented Jan 4, 2025

I cherry-picked the unit test you contributed here: 8720632 Thanks for your contributions anyway, @saicao

The rest of this PR shall be either superseded by #2028 or need further discussion. Please see my comments above.

@wtdcode wtdcode closed this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants