Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2103: qemu/target/ppc/mem_helper.c remove redundant returns #2104

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

disconnect3d
Copy link
Contributor

@disconnect3d disconnect3d commented Feb 14, 2025

This fixes the issue described in #2103 - compilation errors when building Unicorn Engine:

/build/unicorn-2.1.2/src/qemu/target/ppc/mem_helper.c: In function ‘helper_stq_le_parallel’:
/build/unicorn-2.1.2/src/qemu/target/ppc/mem_helper.c:423:12: error: ‘return’ with a value, in function returning void [-Wreturn-mismatch]
  423 |     return 0;
      |            ^
/build/unicorn-2.1.2/src/qemu/target/ppc/mem_helper.c: In function ‘helper_stq_be_parallel’:
/build/unicorn-2.1.2/src/qemu/target/ppc/mem_helper.c:439:12: error: ‘return’ with a value, in function returning void [-Wreturn-mismatch]
  439 |     return 0;
      |            ^

As pointed by @patryk4815

Since GCC 14, the -Wreturn-mismatch warning has been promoted to an error by default (as mentioned here).

@disconnect3d disconnect3d changed the title Fix #2103: qemu/target/ppc/mem_helper.c remove redundant return state… Fix #2103: qemu/target/ppc/mem_helper.c remove redundant returns Feb 14, 2025
@wtdcode
Copy link
Member

wtdcode commented Feb 14, 2025

Oh… this was introduced by me when refactoring the related code😱

@wtdcode wtdcode merged commit d03c092 into unicorn-engine:master Feb 14, 2025
36 checks passed
@wtdcode
Copy link
Member

wtdcode commented Feb 14, 2025

Thanks!

@patryk4815
Copy link

Oh… this was introduced by me when refactoring the related code😱

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants