Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Workflow: Fix aarch64 build bug introduced with previous refactoring #2106 #2107

Merged
merged 1 commit into from
Feb 17, 2025
Merged

GitHub Workflow: Fix aarch64 build bug introduced with previous refactoring #2106 #2107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 6 additions & 20 deletions .github/workflows/Nuget-publishing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,9 @@ jobs:
- {
os: windows-2022,
arch: x64,
python-arch: x64,
python-ver: '3.8',
name: 'windows-x64 MSVC 64bit shared',
msvc-arch: x64,
artifact: 'windows_msvc64_shared.7z',
artifact: 'windows-msvc64-shared.7z',
shared: 'yes',
build_type: 'Release',
archiver: '7z a',
Expand All @@ -50,11 +48,9 @@ jobs:
- {
os: windows-2022,
arch: x86,
python-arch: x86,
python-ver: '3.8',
name: 'windows-x86 MSVC 32bit shared',
msvc-arch: x86,
artifact: 'windows_msvc32_shared.7z',
artifact: 'windows-msvc32-shared.7z',
shared: 'yes',
build_type: 'Release',
archiver: '7z a',
Expand Down Expand Up @@ -148,8 +144,6 @@ jobs:
- {
os: macos-latest,
arch: x64,
python-arch: x64,
python-ver: '3.8',
name: 'macos-x64 cmake shared',
shared: 'yes',
artifact: 'macos-cmake-shared-x64.7z',
Expand Down Expand Up @@ -206,8 +200,6 @@ jobs:
- {
os: ubuntu-latest,
arch: x64,
python-arch: x64,
python-ver: '3.8',
name: 'ubuntu-x64 cmake shared',
shared: 'yes',
artifact: 'ubuntu-cmake-shared-x64.7z',
Expand All @@ -218,8 +210,6 @@ jobs:
- {
os: ubuntu-latest,
arch: x86,
python-arch: x86,
python-ver: '3.8',
name: 'ubuntu-x86 cmake shared',
shared: 'yes',
artifact: 'ubuntu-cmake-shared-x86.7z',
Expand All @@ -230,8 +220,6 @@ jobs:
- {
os: ubuntu-24.04-arm,
arch: aarch64,
python-arch: aarch64,
python-ver: '3.8',
name: 'ubuntu-aarch64 cmake',
artifact: 'ubuntu-cmake-aarch64.7z',
build_type: 'Release',
Expand All @@ -242,8 +230,6 @@ jobs:
- {
os: ubuntu-22.04,
arch: ppc64le,
python-arch: ppc,
python-ver: '3.8',
name: 'ubuntu-ppc64le cmake',
artifact: 'ubuntu-cmake-ppc64le.7z',
build_type: 'Release',
Expand Down Expand Up @@ -295,9 +281,9 @@ jobs:
-B . \
-DCMAKE_BUILD_TYPE=${{ matrix.config.build_type }} \
-G "${{ matrix.config.generators }}" \
-DCMAKE_INSTALL_PREFIX:PATH=/instdir
-DCMAKE_INSTALL_PREFIX:PATH=instdir
cmake --build . --config ${{ matrix.config.build_type }}
sudo cmake --install . --strip
cmake --install . --strip
ctest -VV -C ${{ matrix.config.build_type }}

- name: '🚧 Linux ppc64le build'
Expand Down Expand Up @@ -388,13 +374,13 @@ jobs:
"destDir": "runtimes/osx-x64/native",
"destFile": "libunicorn.dylib"
},
"windows_msvc64_shared.7z": {
"windows-msvc64-shared.7z": {
"sourceDir": "",
"sourceFile": "unicorn.dll",
"destDir": "runtimes/win-x64/native",
"destFile": "unicorn.dll"
},
"windows_msvc32_shared.7z": {
"windows-msvc32-shared.7z": {
"sourceDir": "",
"sourceFile": "unicorn.dll",
"destDir": "runtimes/win-x86/native",
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build-uc2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,9 +487,9 @@ jobs:
-B . \
-DCMAKE_BUILD_TYPE=${{ env.BUILD_TYPE }} \
-G "${{ matrix.config.generators }}" \
-DCMAKE_INSTALL_PREFIX:PATH=/instdir
-DCMAKE_INSTALL_PREFIX:PATH=instdir
cmake --build . --config ${{ env.BUILD_TYPE }}
sudo cmake --install . --strip
cmake --install . --strip
ctest -VV -C ${{ env.BUILD_TYPE }}

- name: '🚧 Linux ppc64le build'
Expand Down
Loading