Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python bindings: Port pkg_resources to importlib_resources for python < 3.9 #2123

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Python bindings: Port pkg_resources to importlib_resources for python < 3.9 #2123

merged 2 commits into from
Mar 4, 2025
+12 −13

Conversation

Antelox
Copy link
Contributor

@Antelox Antelox commented Mar 3, 2025

Take over of #2122

Closes: #1829

Thanks to @Arusekk

Arusekk
Arusekk approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@Arusekk Arusekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks better than mine and works for me.

@wtdcode wtdcode merged commit f183810 into unicorn-engine:master Mar 4, 2025
34 of 38 checks passed
@wtdcode wtdcode mentioned this pull request Mar 4, 2025
Closed
@Antelox Antelox deleted the bindings/python branch March 4, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arusekk Arusekk Arusekk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python bindings: DeprecationWarning of pkg_resources when using Unicorn through pytest
3 participants
@Antelox @Arusekk @wtdcode