feat: improved endpoint detection #21009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs to be tested with a Hilla build from this PR branch |
mshabarov
requested changes
Feb 21, 2025
| /** | ||
| * Checks if Hilla is available and Hilla endpoints are used in the project. | ||
| * | ||
| * @return {@code true} if Hilla is available and Hilla views are used, |
There was a problem hiding this comment.
Suggested change
| * @return {@code true} if Hilla is available and Hilla views are used, | |
| * @return {@code true} if Hilla is available and Hilla endpoints are used, |
| @@ -319,6 +319,9 @@ private void addEndpointServicesTasks(Options options) { | |||
| if (!EndpointRequestUtil.isHillaAvailable(options.getClassFinder())) { | |||
| return; | |||
| } | |||
| if (!EndpointRequestUtil.areHillaEndpointsUsed(options)) { | |||
There was a problem hiding this comment.
What if views are there but no endpoints yet?
I'd do it in this way:
- If Hilla not available - return
- if endpoints are used or views are used - continue, else - return.
flow-server/src/main/java/com/vaadin/flow/server/frontend/NodeUpdater.java
Show resolved
Hide resolved
Comment on lines
+565
to
+568
| if (endpointGeneratorTaskFactory != null) { | ||
| annotations.addAll(endpointGeneratorTaskFactory | ||
| .getBrowserCallableAnnotations()); | ||
| } |
There was a problem hiding this comment.
This doesn't seem to be covered by tests, so needs a unit test.
|
Works as expected for me. |
|
mshabarov
approved these changes
Feb 25, 2025
mshabarov
added a commit
that referenced
this pull request
Feb 25, 2025
This reverts commit 530e757.
tepi
pushed a commit
that referenced
this pull request
Feb 25, 2025
|
This ticket/PR has been released with Vaadin 24.7.0.alpha12 and is also targeting the upcoming stable 24.7.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20983