You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
feat: better error when not enough scopes for SSO login (#9948)
### Description
When you already have a token but don't have SSO scopes, we were
throwing an error that didn't have much information. The error should be
more clear now when you are in this state, informing you to use
`--force`.
Specifically you could get into this state by doing:
```
turbo login
turbo login --sso-team=my-team
```
#### Note
I happy-pathed (error-pathed?) this for the specific case I wanted to
solve for. I'm not sure if this is accidentally changing the error for
other problematic states you can be in.
### Testing Instructions
I'm struggling to write a unit test. Help would be appreciate if you
think one would be good for this (I do).
Additionally, here's a before and after:
Before:
```
▲ 👟 turbo on shew/6b0e1
turbo login
turbo 2.4.0
>>> Opening browser to https://vercel.com/turborepo/token?redirect_uri=redacted
>>> Success! Turborepo CLI authorized for [email protected]
To connect to your Remote Cache, run the following in any turborepo:
npx turbo link
▲ 👟 turbo on shew/6b0e1 took 6s
turbo login --sso-team=my-team
turbo 2.4.0
× Error making HTTP request: HTTP status client error (403 Forbidden) for url (https://vercel.com/api/v2/teams/my-team)
╰─▶ HTTP status client error (403 Forbidden) for url (https://vercel.com/api/v2/teams/my-team)
```
After:
```
▲ 👟 turbo on shew/6b0e1
dt login
turbo 2.4.2-canary.0
>>> Opening browser to https://vercel.com/turborepo/token?redirect_uri=redacted
>>> Success! Turborepo CLI authorized for [email protected]
To connect to your Remote Cache, run the following in any turborepo:
npx turbo link
▲ 👟 turbo on shew/6b0e1 took 2s
dt login --sso-team=my-team
turbo 2.4.2-canary.0
× [HTTP 403] request to https://vercel.com/api/v2/teams/my-team returned "HTTP status client error (403 Forbidden) for url (https://vercel.com/api/v2/teams/my-team)"
│ Try logging in again, or force a refresh of your token (turbo login --sso-team=your-team --force).
```
---------
Co-authored-by: Chris Olszewski <[email protected]>
0 commit comments