-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve control plane endpoint when updating service #180
Resolve control plane endpoint when updating service #180
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
==========================================
+ Coverage 36.34% 36.54% +0.19%
==========================================
Files 20 20
Lines 2724 2731 +7
==========================================
+ Hits 990 998 +8
Misses 1675 1675
+ Partials 59 58 -1
|
Signed-off-by: Lubron Zhan <[email protected]>
Signed-off-by: Lubron Zhan <[email protected]>
Signed-off-by: Lubron Zhan <[email protected]>
2b6319b
to
c1a851a
Compare
Signed-off-by: Lubron Zhan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the most part, looks good. Just a question though, does the DNS resolver support IPv6?
yes it does
Once we support ipv6 as control plane HA, when AKO supports it, we could add more tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that makes sense. For some reason I thought this was part of the change
return ips[0].String(), err |
and I wasn't sure which IP family this returned.
But it seems like existing behavior so this PR looks good to me.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes ##178
Describe testing done for PR:
Special notes for your reviewer:
Release note:
New PR Checklist