Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.10.0: Run required actions on all changes #217

Conversation

sunjayBhatia
Copy link
Contributor

What this PR does / why we need it:

Previously required actions would not run and PRs were not mergeable since they only ran on a subset of files in the repo.

Same as #188 but for the release branch

Which issue(s) this PR fixes:

N/A

Describe testing done for PR:

N/A

Special notes for your reviewer:

Release note:

NONE

New PR Checklist

  • Ensure PR contains only public links or terms
  • Use good commit messages
  • Squash the commits in this branch before merge to preserve our git history
  • If this PR is just an idea or POC, use a Draft PR instead of a full PR
  • Add appropriate labels according to what type of issue is being addressed.

@lubronzhan
Copy link
Contributor

Now you just need rebase

Previously required actions would not run and PRs were not
mergeable since they only ran on a subset of files in the repo.

Signed-off-by: Sunjay Bhatia <[email protected]>
@sunjayBhatia sunjayBhatia force-pushed the 1.10.0-run-actions-all-prs branch from 067b55c to d49d093 Compare May 2, 2024 19:20
@sunjayBhatia
Copy link
Contributor Author

should be good to go now!

Copy link
Contributor

@lubronzhan lubronzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sunjayBhatia sunjayBhatia merged commit 395f172 into vmware-tanzu:release-1.10.0 May 3, 2024
4 checks passed
@sunjayBhatia sunjayBhatia deleted the 1.10.0-run-actions-all-prs branch May 3, 2024 00:24
christianang pushed a commit to christianang/load-balancer-operator-for-kubernetes that referenced this pull request May 8, 2024
Previously required actions would not run and PRs were not
mergeable since they only ran on a subset of files in the repo.

Signed-off-by: Sunjay Bhatia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants