Fix query parameter encoding for Avi 30.1.1+ #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianang
changed the title
|
Found the flaky test in your integration-test result. Created this fix #239 |
- uses current latest on v30.2.1 branch to consume fix for query encoding rest parameters, which is necessary to work with Avi 30.1.1+ Signed-off-by: Christian Ang <[email protected]>
Signed-off-by: Christian Ang <[email protected]>
|
Rebased with the fix and it looks like tests now pass. This should be good to go if you'd like to review. |
lubronzhan
reviewed
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR uses current latest alb-sdk on v30.2.1 branch to consume fix for query encoding rest parameters and fixes local avi client implementation, which is necessary to work with Avi 30.1.1+.
Which issue(s) this PR fixes:
Fixes n/a
Describe testing done for PR:
Tested on a local cluster with Avi 30.1.1 and the webhook at least works. Didn't have a full cluster-api setup to test further than that. Although it github PR e2e tests pass it should be fine.
Special notes for your reviewer:
Release note:
New PR Checklist