Add ReplicaCount to AKODeploymentConfig #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianang
force-pushed
the
configurable-ako-replicaset
branch
from
1b61e4b to
5026df8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
==========================================
+ Coverage 31.01% 31.42% +0.40%
==========================================
Files 31 31
Lines 2879 2896 +17
==========================================
+ Hits 893 910 +17
Misses 1916 1916
Partials 70 70
|
lubronzhan
reviewed
May 7, 2024
There was a problem hiding this comment.
Changes overall look good. Could you add a validation inside the validation webhook?
https://github.com/vmware-tanzu/load-balancer-operator-for-kubernetes/blob/main/api/v1alpha1/akodeploymentconfig_webhook.go
christianang
force-pushed
the
configurable-ako-replicaset
branch
2 times, most recently
from
f1fa253 to
1b1516e
Compare
Added. |
flawedmatrix
reviewed
May 7, 2024
Signed-off-by: Christian Ang <[email protected]>
christianang
force-pushed
the
configurable-ako-replicaset
branch
from
1b1516e to
09db096
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds
spec.extraConfigs.replicaCounttoAKODeploymentConfig, which will set theloadBalancerAndIngressService.config.replica_countfield in theload-balancer-and-ingress-service-data-valuessecret.I also left the default if the field is unset at 1.
Which issue(s) this PR fixes:
Fixes #247
Describe testing done for PR:
Created an
AKODeploymentConfigwith a replica count of two and see that the data values was configured correctly. I also see two ako instances on my cluster.Special notes for your reviewer:
Release note:
New PR Checklist