Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.12][TKG-29306] Filter user permission #396

Conversation

lubronzhan
Copy link
Contributor

What this PR does / why we need it:
Cherry pick https://github.com/vmware-tanzu/load-balancer-operator-for-kubernetes/pull/369/commits

Filter permissions, remove the one that's been deprecated in corresponding AVI Controller version
Add username to user object if it's enterprise license
More logging
Refactor makefile and dockerfile

Which issue(s) this PR fixes:

Fixes #

Describe testing done for PR:

Special notes for your reviewer:

Release note:


New PR Checklist

  • Ensure PR contains only public links or terms
  • Use good commit messages
  • Squash the commits in this branch before merge to preserve our git history
  • If this PR is just an idea or POC, use a Draft PR instead of a full PR
  • Add appropriate labels according to what type of issue is being addressed.

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 15.00000% with 51 lines in your changes missing coverage. Please review.

Project coverage is 31.91%. Comparing base (7b3e3e4) to head (f2b66ea).

Files with missing lines Patch % Lines
...ollers/akodeploymentconfig/user/user_controller.go 17.64% 42 Missing ⚠️
controllers/akodeploymentconfig/user/ako_role.go 0.00% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-1.12     #396      +/-   ##
================================================
- Coverage         32.16%   31.91%   -0.25%     
================================================
  Files                32       33       +1     
  Lines              3616     3653      +37     
================================================
+ Hits               1163     1166       +3     
- Misses             2383     2417      +34     
  Partials             70       70              
Files with missing lines Coverage Δ
controllers/akodeploymentconfig/user/ako_role.go 0.00% <0.00%> (ø)
...ollers/akodeploymentconfig/user/user_controller.go 9.55% <17.64%> (+0.10%) ⬆️

Copy link
Contributor

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just needs a rebase to get lint CI green again

@lubronzhan lubronzhan force-pushed the topic/lubron/test_avi_vc9_1.12 branch from 0bb0181 to f2b66ea Compare February 14, 2025 01:45
@lubronzhan
Copy link
Contributor Author

Cool rebased @sunjayBhatia

@lubronzhan lubronzhan merged commit ba78a13 into vmware-tanzu:release-1.12 Feb 14, 2025
4 checks passed
@lubronzhan lubronzhan deleted the topic/lubron/test_avi_vc9_1.12 branch February 14, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants