Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(refManualReset): new function #4644

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(refManualReset): new function #4644

wants to merge 1 commit into from
+78 −0

Conversation

phk422
Copy link
Contributor

@phk422 phk422 commented Mar 5, 2025

via: #4564

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Mar 5, 2025
@phk422 phk422 force-pushed the feature/refManualReset branch 2 times, most recently from 34916dd to 77458bf Compare March 5, 2025 08:52
@phk422 phk422 force-pushed the feature/refManualReset branch from 77458bf to 636541c Compare March 5, 2025 08:54
@ferferga
Copy link
Member

Instead of a new function... Why we don't adapt the current one so, when an undefined or null timeout is passed, it does what's proposed in the issue?

@phk422
Copy link
Contributor Author

phk422 commented Mar 14, 2025 •
edited
Loading

Instead of a new function... Why we don't adapt the current one so, when an undefined or null timeout is passed, it does what's proposed in the issue?

Thank you for your suggestion! Considering that the semantics of refAutoRest are clearly tied to "Auto," directly modifying it might not be appropriate. Therefore, I have added a separate method. Additionally, we can use the refReset method and differentiate between automatic and manual modes through parameters. If you agree, I can further refine this solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request new function size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phk422 @ferferga @ilyaliao