fix: update types to be compatible with v10

[wolfy1339]

No description provided.

[wheresrhys]

Thanks for this

[wolfy1339]

Unfortunately, your further commit ae15739 has broken the types again.

Now the package is unusable in ESM with TypeScript currently

It seems that there needs to be types for both ESM and CJS

[wheresrhys]

Sorry, but there was something about your commit that also broke the types for the use cases the CI covers. Can you please share more details of your setup, ideally a small repo which installs fetch-mock and has the typescript config you use

…

On Tue, Jun 18, 2024 at 4:05 PM wolfy1339 ***@***.***> wrote: Unfortunately, your further commit ae15739 <ae15739> has broken the types again. Now the package is unusable in ESM with TypeScript currently It seems that there needs to be types for both ESM and CJS — Reply to this email directly, view it on GitHub <#680 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADNIR4BWPMNGKG5GQHATHLZIBEDNAVCNFSM6AAAAABJONQS6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZWGMZTINRXGA> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[wolfy1339]

The CI case handles CJS, and can be updated for dual-support. I get that it broke, it can be fixed

We use fetch-mock all over the @octokit org for the JS packages

Specifically this repo: octokit/core.js#686
It might not be the smallest, but it show the issue and how the issue is not present before

The error I am getting is the following:

test/issues.test.ts:2:8 - error TS1192: Module '"/home/runner/work/core.js/core.js/node_modules/fetch-mock/types/index"' has no default export.

Since the types only have CJS exports, TS complains. Runtime is fine

[wolfy1339]

I created a minimal reproducible test case, https://stackblitz.com/edit/fetch-mock-680?file=index.ts

[wheresrhys]

Thank you

[wheresrhys]

I think this has fixed the tests and I've reverted to your original change too https://github.com/wheresrhys/fetch-mock/blob/main/types/fetch-mock-tests.ts#L1C1-L1C28

Thanks for the pointers