forked from apache/sedona
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RS_ZonalStats and RS_ZonalStatsAll edge case bug #49
Closed
furqaankhan
wants to merge
20
commits into
wherobots:master
from
furqaankhan:furqaankhan/fix-zonal-stats
Closed
Fix RS_ZonalStats and RS_ZonalStatsAll edge case bug #49
furqaankhan
wants to merge
20
commits into
wherobots:master
from
furqaankhan:furqaankhan/fix-zonal-stats
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he#1843) * [SEDONA-720] Add GeoPandas Compatible API on Sedona - framework * temporarily disable lower python versions on ci * fix python tests and revert ci python pipeline * fix lint issue * remove numpy dtypes import * fix TestDataframe * add more functions to geodataframe implementation * remove schema print and show * Update version to 1.8.0 * Remove show and printSchema --------- Co-authored-by: Jia Yu <[email protected]>
…pache#1856) Bumps [net.snowflake:snowflake-jdbc](https://github.com/snowflakedb/snowflake-jdbc) from 3.22.0 to 3.23.1. - [Release notes](https://github.com/snowflakedb/snowflake-jdbc/releases) - [Changelog](https://github.com/snowflakedb/snowflake-jdbc/blob/master/CHANGELOG.rst) - [Commits](snowflakedb/snowflake-jdbc@v3.22.0...v3.23.1) --- updated-dependencies: - dependency-name: net.snowflake:snowflake-jdbc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Speed up the script * Update Snowflake tester version * Update the year in NOTICE
…dinates from double to float (apache#1860)
* [SEDONA-704] Optimize STAC reader and fix few issues * fix formating issue * fix compiling error * another fix
* [SEDONA-715] Update sedona-jupyterlab.dockerfile Did you read the Contributor Guide? Yes, I have read Contributor Rules and Contributor Development Guide Is this PR related to a JIRA ticket? Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-715. The PR name follows the format [SEDONA-XXX] my subject. What changes were proposed in this PR? Bug fix, zeppelin config is dynamically inferred now during build. How was this patch tested? Tested locally by building the image and running it. Visualized with the sample notebook that has been bundled with the commit. Did this PR include necessary documentation updates? Yes, added additional information that may help the users. * Update sedona-jupyterlab.dockerfile * Fix the docker build * Add some update * Get the image build working with docker cache * Bring back the full spark distribution * Fix again * Use the classic ui * All code are working now * Update pre-commit * Drop the binder folder completely * Wrap up the Zeppelin example * Fix a number of issues in Jupyter * Test all jupyter notebooks --------- Co-authored-by: Jia Yu <[email protected]>
Co-authored-by: jameswillis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[SEDONA-724] my subject
.What changes were proposed in this PR?
When the ROI barely intersects with the input raster's extent and the
allTouched
argument is false then this causes the pixel data to be empty. That breaks the zonalMode method which assumes there will be pixel data.Add better error handling and a shortcut for RS_ZonalStatsAll to skip unnecessary stats compute (saves ~6% time).
How was this patch tested?
Did this PR include necessary documentation updates?