Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RS_ZonalStats and RS_ZonalStatsAll edge case bug #49

Closed

Conversation

furqaankhan
Copy link
Collaborator

Did you read the Contributor Guide?

Is this PR related to a ticket?

  • Yes, and the PR name follows the format [SEDONA-724] my subject.

What changes were proposed in this PR?

When the ROI barely intersects with the input raster's extent and the allTouched argument is false then this causes the pixel data to be empty. That breaks the zonalMode method which assumes there will be pixel data.

Add better error handling and a shortcut for RS_ZonalStatsAll to skip unnecessary stats compute (saves ~6% time).

How was this patch tested?

  • add unit tests

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

jiayuasu and others added 16 commits March 10, 2025 18:52
…he#1843)

* [SEDONA-720] Add GeoPandas Compatible API on Sedona - framework

* temporarily disable lower python versions on ci

* fix python tests and revert ci python pipeline

* fix lint issue

* remove numpy dtypes import

* fix TestDataframe

* add more functions to geodataframe implementation

* remove schema print and show

* Update version to 1.8.0

* Remove show and printSchema

---------

Co-authored-by: Jia Yu <[email protected]>
…pache#1856)

Bumps [net.snowflake:snowflake-jdbc](https://github.com/snowflakedb/snowflake-jdbc) from 3.22.0 to 3.23.1.
- [Release notes](https://github.com/snowflakedb/snowflake-jdbc/releases)
- [Changelog](https://github.com/snowflakedb/snowflake-jdbc/blob/master/CHANGELOG.rst)
- [Commits](snowflakedb/snowflake-jdbc@v3.22.0...v3.23.1)

---
updated-dependencies:
- dependency-name: net.snowflake:snowflake-jdbc
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Speed up the script

* Update Snowflake tester version

* Update the year in NOTICE
* [SEDONA-704] Optimize STAC reader and fix few issues

* fix formating issue

* fix compiling error

* another fix
* [SEDONA-715] Update sedona-jupyterlab.dockerfile

Did you read the Contributor Guide?
Yes, I have read Contributor Rules and Contributor Development Guide

Is this PR related to a JIRA ticket?
Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-715. The PR name follows the format [SEDONA-XXX] my subject.

What changes were proposed in this PR?
Bug fix, zeppelin config is dynamically inferred now during build.

How was this patch tested?
Tested locally by building the image and running it. Visualized with the sample notebook that has been bundled with the commit.

Did this PR include necessary documentation updates?
Yes, added additional information that may help the users.

* Update sedona-jupyterlab.dockerfile

* Fix the docker build

* Add some update

* Get the image build working with docker cache

* Bring back the full spark distribution

* Fix again

* Use the classic ui

* All code are working now

* Update pre-commit

* Drop the binder folder completely

* Wrap up the Zeppelin example

* Fix a number of issues in Jupyter

* Test all jupyter notebooks

---------

Co-authored-by: Jia Yu <[email protected]>
@jiayuasu jiayuasu closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants