-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Folder reconfig, adding reading data notebook, and Onboarding 4 notebook #38
base: main
Are you sure you want to change the base?
Conversation
Found 17 changed notebooks. Review the changes at https://app.gitnotebooks.com/wherobots/wherobots-examples/pull/38 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We really shouldn't be storing datasets here. IIRC those assets were more images and configs and just needs a rename. I was hoping we could look at a much more of a flat structure and consistency in the naming. Something like
When there is a hard requirement for a GPU or other org upgrade we highlight that the top of the first cell. |
something more like this with consistent naming cc @jiayuasu @james-willis @rbavery
|
@RoboDonut so there are not datasets just notebooks to connect to data - namely Out-DB rasters. This is meant to capture some of the Earth Engine audience. For the naming I tend to lean away from feature based naming. I think that is fine for existing customers or those who have spent time with our platform but for those who haven't it tends to be a bit confusing as in they don't know what they need yet. If we go on a more use case naming that might be a bit easier. |
I prefer Feature based naming without long file names including the product and language. This gets repetitive imo and I think a more nested folder structure would be easier to view and navigate for first time and long time users. Features can be named by commonly understood terms rather than our particular product name (so we could avoid putting Havasu in the name) Agree on not having a folder called "datasets" I would expect to find data in there. We could look to some existing examples for inspiration. I like how this community example for GEE separates "Feature" focused notebooks from more conceptual notebooks that integrate multiple features like "HowEarthEngineWorks" or "Tutorials". In cases where we have scala examples (uncommon) we could have only a scala subfolder rather than an additional python folder |
@RoboDonut @prantogg @rbavery added new changes based on the above feedback. I went with:
We will need to decide on - vs _ and then capitalization vs all lower case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Folder structure LGTM. I prefer _ over - in file names.
_ makes selecting files name with double click much easier.
I think that's the old structure @james-willis and agree. Love the new update @mbforr https://github.com/wherobots/wherobots-examples/tree/48816a1c38a01c981a0960ad77a5ded03775044b I see we use wherobots-db in a handful of places which I don't mind for some features which are extra unique to Wherobots, and since they don't occur in folders with lots of repetitive product names. |
snippets
section with code snippets and one new notebook