Change configuration loading to cosmiconfig #420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YAML is disabled.
pvdlg
reviewed
Feb 13, 2020
lib/options-manager.js
Outdated
| `${moduleName}.config.js`]; | ||
| const loaders = {noExt: defaultLoaders['.json']}; | ||
| // Change working directory for load config | ||
| process.chdir(options.cwd); |
There was a problem hiding this comment.
Instead of changing the working directory directory, pass options.cwd to comisconfig in option searchFrom: https://github.com/davidtheclark/cosmiconfig#searchfrom
There was a problem hiding this comment.
Done. I didn't saw this option before.
|
Thanks for working on this. It would be good with some more tests. And it also needs to be documented in the readme. |
|
I added tests for every variety and changed the docs with my latest commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed configuration loading to cosmiconfig module. As @sindresorhus mention YAML is disabled.
Fixes issue #330 and superseded PR #331 as this seems no longer maintained.