Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authhelper: Expose Client Script Auth via the API #6277

Merged
merged 1 commit into from
Mar 19, 2025
Merged

authhelper: Expose Client Script Auth via the API #6277

merged 1 commit into from
Mar 19, 2025

Conversation

kingthorin
Copy link
Member

@kingthorin kingthorin commented Mar 14, 2025 •
edited
Loading

Overview

Allow the Client Script Authentication method type to be exposed and configured via the API.

Confirmed via the Web API UI (w/ zaproxy/zaproxy#8885) that it is listed separately and configurable.

Related Issues

N/A

Checklist

  • Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

@kingthorin kingthorin force-pushed the csa-api-dynamic-impl branch 2 times, most recently from 4a0d3ea to 9fca7ef Compare March 14, 2025 17:51
@psiinon
Copy link
Member

psiinon commented Mar 14, 2025 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – a3c0e6d8-6a6d-4aba-a59f-43da840bdfd0

Fixed Issues (1)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
LOW Use_Of_Hardcoded_Password /addOns/authhelper/src/test/java/org/zaproxy/addon/authhelper/internal/ClientSideHandlerUnitTest.java: 67

thc202
thc202 reviewed Mar 18, 2025
View reviewed changes
@kingthorin kingthorin force-pushed the csa-api-dynamic-impl branch from 9fca7ef to f5b791d Compare March 18, 2025 22:17
@kingthorin
Copy link
Member Author

Done & done.

@kingthorin kingthorin force-pushed the csa-api-dynamic-impl branch from f5b791d to cc04d19 Compare March 19, 2025 09:15
@thc202
Copy link
Member

thc202 commented Mar 19, 2025

Thank you!

@psiinon psiinon merged commit d83f2ee into zaproxy:main Mar 19, 2025
9 of 10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2025
@kingthorin kingthorin deleted the csa-api-dynamic-impl branch March 19, 2025 11:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@psiinon psiinon psiinon approved these changes

@thc202 thc202 thc202 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kingthorin @psiinon @thc202