Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #201162 godlikeproductions.com #201178

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ntnguyen1234
Copy link
Member

Fix #201162

They have a bunch of inline scripts so I choose remove-node-text.

Comment on lines +1127 to +1128
godlikeproductions.com#%#//scriptlet('remove-node-text', 'script', '/alert|blocker|brave/i')
godlikeproductions.com#%#//scriptlet('prevent-addEventListener', 'DOMContentLoaded', '.onerror')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I see only an ad leftover, which is covered by your rule in specific.txt Even no request to adsbygoogle.
@AdamWr @zloyden Please take a look.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also cannot reproduce adsbygoogle.js request.
I see godlikeproductions.com/adblock_check.php request (which contains incognito and adblock detection), so maybe we could block it instead of unblocking requests?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not reproduced on my end.

I see godlikeproductions.com/adblock_check.php request (which contains incognito and adblock detection), so maybe we could block it instead of unblocking requests?

I guess it can be blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

www.godlikeproductions.com
4 participants