Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #201162 godlikeproductions.com #201178

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion BaseFilter/sections/antiadblock.txt
Original file line number Diff line number Diff line change
@@ -1123,6 +1123,13 @@ youporn.com$$script:contains(/window\.[\s\S]*?_zone_[\s\S]*?{"zone_id":/)
!
! NOTE: Regular rules
!
! https://github.com/AdguardTeam/AdguardFilters/issues/201162
godlikeproductions.com#%#//scriptlet('remove-node-text', 'script', '/alert|blocker|brave/i')
godlikeproductions.com#%#//scriptlet('prevent-addEventListener', 'DOMContentLoaded', '.onerror')
Comment on lines +1127 to +1128
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I see only an ad leftover, which is covered by your rule in specific.txt Even no request to adsbygoogle.
@AdamWr @zloyden Please take a look.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also cannot reproduce adsbygoogle.js request.
I see godlikeproductions.com/adblock_check.php request (which contains incognito and adblock detection), so maybe we could block it instead of unblocking requests?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not reproduced on my end.

I see godlikeproductions.com/adblock_check.php request (which contains incognito and adblock detection), so maybe we could block it instead of unblocking requests?

I guess it can be blocked.

!#if (adguard_ext_safari || adguard_app_ios || adguard_ext_android_cb)
@@||pagead2.googlesyndication.com/pagead/js/adsbygoogle.js$domain=godlikeproductions.com
@@||cdn.jsdelivr.net/gh/*/detectIncognito$domain=godlikeproductions.com
!#endif
!https://github.com/AdguardTeam/AdguardFilters/issues/201055
interfans.org#%#//scriptlet('remove-node-text', 'script', 'adBlockAction')
!+ PLATFORM(ios, ext_android_cb, ext_safari)
@@ -12785,4 +12792,4 @@ dirtstyle.tv##.lightbox
! https://github.com/AdguardTeam/AdguardFilters/issues/111850
bigbrothercanada.ca#%#//scriptlet('set-constant', 'video_player_config.players.0.adblock', 'false')
!+ PLATFORM(ios, ext_android_cb)
@@||bigbrothercanada.ca^$generichide
@@||bigbrothercanada.ca^$generichide
1 change: 1 addition & 0 deletions BaseFilter/sections/specific.txt
Original file line number Diff line number Diff line change
@@ -566,6 +566,7 @@ $subdocument,third-party,denyallow=disqus.com,domain=welovemanga.one
! NOTE: Specific rules
!
!
godlikeproductions.com##.rightpanel_ipad > div:has(> center > [data-type="_mgwidget"])
ww2-weapons.com###sgpb-popup-dialog-main-div-wrapper
ww2-weapons.com##.sgpb-popup-overlay
ww2-weapons.com##[class*="warhist-"]