Deprecating global seeding, updating tests #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorbonas
reviewed
Mar 5, 2025
trevorbonas
reviewed
Mar 5, 2025
cmd/tsbs_generate_queries/databases/timestream/devops_single_measure_test.go
Show resolved
Hide resolved
|
Running $ go test ./...
? github.com/timescale/tsbs/cmd/tsbs_generate_data [no test files]
? github.com/timescale/tsbs/cmd/tsbs_generate_queries [no test files]
? github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases [no test files]
? github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/akumuli [no test files]
FAIL github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/cassandra [build failed]
FAIL github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/clickhouse [build failed]
FAIL github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/cratedb [build failed]
FAIL github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/influx [build failed]
? github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/mongo [no test files]
FAIL github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/questdb [build failed]
FAIL github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/siridb [build failed]
FAIL github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/timescaledb [build failed]
ok github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/timestream 0.386s
FAIL github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/victoriametrics [build failed]
ok github.com/timescale/tsbs/cmd/tsbs_generate_queries/uses/common 0.210s
ok github.com/timescale/tsbs/cmd/tsbs_generate_queries/uses/devops 0.483s
? github.com/timescale/tsbs/cmd/tsbs_generate_queries/uses/iot [no test files]
? github.com/timescale/tsbs/cmd/tsbs_generate_queries/utils [no test files]
? github.com/timescale/tsbs/cmd/tsbs_load [no test files]
? github.com/timescale/tsbs/cmd/tsbs_load_akumuli [no test files]
? github.com/timescale/tsbs/cmd/tsbs_load_cassandra [no test files]
? github.com/timescale/tsbs/cmd/tsbs_load_clickhouse [no test files]
ok github.com/timescale/tsbs/cmd/tsbs_load_cratedb 0.470s
ok github.com/timescale/tsbs/cmd/tsbs_load_influx 2.628s
? github.com/timescale/tsbs/cmd/tsbs_load_mongo [no test files]
? github.com/timescale/tsbs/cmd/tsbs_load_prometheus [no test files]
? github.com/timescale/tsbs/cmd/tsbs_load_prometheus/adapter [no test files]
? github.com/timescale/tsbs/cmd/tsbs_load_prometheus/adapter/noop [no test files]
ok github.com/timescale/tsbs/cmd/tsbs_load_questdb 0.823s
ok github.com/timescale/tsbs/cmd/tsbs_load_siridb 0.961s
? github.com/timescale/tsbs/cmd/tsbs_load_timescaledb [no test files]
? github.com/timescale/tsbs/cmd/tsbs_load_victoriametrics [no test files]
? github.com/timescale/tsbs/cmd/tsbs_run_queries_akumuli [no test files]
? github.com/timescale/tsbs/cmd/tsbs_run_queries_cassandra [no test files]
? github.com/timescale/tsbs/cmd/tsbs_run_queries_clickhouse [no test files]
? github.com/timescale/tsbs/cmd/tsbs_run_queries_cratedb [no test files]
? github.com/timescale/tsbs/cmd/tsbs_run_queries_influx [no test files]
? github.com/timescale/tsbs/cmd/tsbs_run_queries_mongo [no test files]
? github.com/timescale/tsbs/cmd/tsbs_run_queries_questdb [no test files]
? github.com/timescale/tsbs/cmd/tsbs_run_queries_siridb [no test files]
? github.com/timescale/tsbs/cmd/tsbs_run_queries_timescaledb [no test files]
? github.com/timescale/tsbs/cmd/tsbs_run_queries_timestream [no test files]
? github.com/timescale/tsbs/cmd/tsbs_run_queries_victoriametrics [no test files]
FAILResults prefixed with For the failures, using $ cd cmd/tsbs_generate_queries/databases/influx && go clean -testcache && go test -v
# github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/influx [github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/influx.test]
./devops_test.go:41:51: not enough arguments in call to b.NewDevops
have (time.Time, time.Time, number)
want (time.Time, time.Time, int, int64)
./devops_test.go:80:51: not enough arguments in call to b.NewDevops
have (time.Time, time.Time, number)
want (time.Time, time.Time, int, int64)
./devops_test.go:124:51: not enough arguments in call to b.NewDevops
have (time.Time, time.Time, number)
want (time.Time, time.Time, int, int64)
./devops_test.go:153:31: not enough arguments in call to b.NewDevops
have (time.Time, time.Time, number)
want (time.Time, time.Time, int, int64)
./devops_test.go:183:31: not enough arguments in call to b.NewDevops
have (time.Time, time.Time, number)
want (time.Time, time.Time, int, int64)
./devops_test.go:295:31: not enough arguments in call to b.NewDevops
have (time.Time, time.Time, number)
want (time.Time, time.Time, int, int64)
./devops_test.go:362:49: not enough arguments in call to b.NewDevops
have (time.Time, time.Time, number)
want (time.Time, time.Time, int, int64)
./devops_test.go:416:33: not enough arguments in call to b.NewDevops
have (time.Time, time.Time, number)
want (time.Time, time.Time, int, int64)
./iot_test.go:92:47: not enough arguments in call to b.NewIoT
have (time.Time, time.Time, number)
want (time.Time, time.Time, int, int64)
./iot_test.go:122:47: not enough arguments in call to b.NewIoT
have (time.Time, time.Time, number)
want (time.Time, time.Time, int, int64)
./iot_test.go:122:47: too many errors
FAIL github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/influx [build failed] |
|
@trevorbonas For the first set of logs, the main set of tests I focused on was for As for the second logs, I created a separate ticket to update the influxdb tests and logic for supporting seed, as this PR was already getting pretty big. |
The rest of the other tests should be updated. Your changes broke them. Interestingly, running tests on $ go test ./...
? github.com/timescale/tsbs/cmd/tsbs_generate_data [no test files]
? github.com/timescale/tsbs/cmd/tsbs_generate_queries [no test files]
? github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases [no test files]
? github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/akumuli [no test files]
# github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/timestream [github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/timestream.test]
tsbs_generate_queries/databases/timestream/devops_test.go:74:15: d.getMeasureNameWhereString undefined (type *Devops has no field or method getMeasureNameWhereString)
ok github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/cassandra 0.225s
ok github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/clickhouse 0.422s
ok github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/cratedb 0.726s
--- FAIL: TestDevopsGetHostWhereString (0.00s)
--- FAIL: TestDevopsGetHostWhereString/single_host (0.00s)
devops_test.go:87: incorrect output:
got
(hostname = 'host_8')
want
(hostname = 'host_1')
--- FAIL: TestDevopsGetHostWhereString/multi_host_(2) (0.00s)
devops_test.go:87: incorrect output:
got
(hostname = 'host_0' or hostname = 'host_1')
want
(hostname = 'host_7' or hostname = 'host_9')
--- FAIL: TestDevopsGetHostWhereString/multi_host_(3) (0.00s)
devops_test.go:87: incorrect output:
got
(hostname = 'host_4' or hostname = 'host_2' or hostname = 'host_3')
want
(hostname = 'host_1' or hostname = 'host_8' or hostname = 'host_5')
FAIL
FAIL github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/influx 0.544s
? github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/mongo [no test files]
ok github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/questdb 0.794s
ok github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/siridb 0.604s
ok github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/timescaledb 0.769s
FAIL github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/timestream [build failed]
ok github.com/timescale/tsbs/cmd/tsbs_generate_queries/databases/victoriametrics 0.936s
ok github.com/timescale/tsbs/cmd/tsbs_generate_queries/uses/common 1.094s
ok github.com/timescale/tsbs/cmd/tsbs_generate_queries/uses/devops 1.177s
? github.com/timescale/tsbs/cmd/tsbs_generate_queries/uses/iot [no test files]
? github.com/timescale/tsbs/cmd/tsbs_generate_queries/utils [no test files]
? github.com/timescale/tsbs/cmd/tsbs_load [no test files]
? github.com/timescale/tsbs/cmd/tsbs_load_akumuli [no test files]
? github.com/timescale/tsbs/cmd/tsbs_load_cassandra [no test files]
? github.com/timescale/tsbs/cmd/tsbs_load_clickhouse [no test files]
ok github.com/timescale/tsbs/cmd/tsbs_load_cratedb 0.666s
ok github.com/timescale/tsbs/cmd/tsbs_load_influx 3.088s
? github.com/timescale/tsbs/cmd/tsbs_load_mongo [no test files]
? github.com/timescale/tsbs/cmd/tsbs_load_prometheus [no test files]
? github.com/timescale/tsbs/cmd/tsbs_load_prometheus/adapter [no test files]
? github.com/timescale/tsbs/cmd/tsbs_load_prometheus/adapter/noop [no test files]
ok github.com/timescale/tsbs/cmd/tsbs_load_questdb 0.818s
ok github.com/timescale/tsbs/cmd/tsbs_load_siridb 0.767s
? github.com/timescale/tsbs/cmd/tsbs_load_timescaledb [no test files]
? github.com/timescale/tsbs/cmd/tsbs_load_victoriametrics [no test files]
? github.com/timescale/tsbs/cmd/tsbs_run_queries_akumuli [no test files]
? github.com/timescale/tsbs/cmd/tsbs_run_queries_cassandra [no test files]
? github.com/timescale/tsbs/cmd/tsbs_run_queries_clickhouse [no test files]
? github.com/timescale/tsbs/cmd/tsbs_run_queries_cratedb [no test files]
? github.com/timescale/tsbs/cmd/tsbs_run_queries_influx [no test files]
? github.com/timescale/tsbs/cmd/tsbs_run_queries_mongo [no test files]
? github.com/timescale/tsbs/cmd/tsbs_run_queries_questdb [no test files]
? github.com/timescale/tsbs/cmd/tsbs_run_queries_siridb [no test files]
? github.com/timescale/tsbs/cmd/tsbs_run_queries_timescaledb [no test files]
? github.com/timescale/tsbs/cmd/tsbs_run_queries_timestream [no test files]
? github.com/timescale/tsbs/cmd/tsbs_run_queries_victoriametrics [no test files]
FAIL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecation of how seeds used to be set (
rand.seed(1337)) required some updates to the core code for general compatibility with other modules.Created a ticket for updating the InfluxDB module with this new approach including updating the tests.