Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all order types in JSON orders #4286

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

islean
Copy link
Contributor

@islean islean commented Mar 13, 2025

Description

We currently only allow for workflows in the JsonOrderformParser. The Raw data workflows such as fastq, metagenome, rml and microbial_fastq suffer as a consequence. Given that some customers want to place JSON orders for some of them, see #4272, we need to support it.

Added

Changed

Fixed

  • JSONOrderformParser supports all order types instead of workflows.

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

Copy link
Contributor

@Vince-janv Vince-janv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@islean islean merged commit 9e19734 into master Mar 13, 2025
9 checks passed
@islean islean deleted the allow-all-order-types-json-orders branch March 13, 2025 15:37
@islean
Copy link
Contributor Author

islean commented Mar 13, 2025

Deployed to the VMs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants