Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow genmod score to run on empty VCF #160

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

fellen31
Copy link
Contributor

@fellen31 fellen31 commented Mar 4, 2025

Description

This adds quality of life improvements to pipelines where genmod is used, by genmod score not failing if a region contains no variants. This is changed by moving the print command after the header updating.

Added

Changed

  • genmod models adds headers to VCF even when it's empty

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_[TOOL]-t [TOOL] -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@fellen31 fellen31 linked an issue Mar 4, 2025 that may be closed by this pull request
@fellen31 fellen31 marked this pull request as ready for review March 4, 2025 15:11
@fellen31 fellen31 requested review from dnil and jemten and removed request for dnil March 4, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scoring an empty VCF
1 participant