-
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All disabled sites include a wildcard in MV3 #3061
Comments
To be exact, when you disable Privacy Badger on
MV2 technically also supports Relevant MV2 disabled site domain matching logic: privacybadger/src/js/background.js Line 996 in cbd036a
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Reading better, I think consistency is the way to go and thus my answer would be no, disabling a site without disabling subdomains is not important. Otherwise I would imagine there to be confusion with mismatching behaviour of tracking sites, if anyone noticed it, and I try to keep my policies in sync between Firefox and Chromium, which I understand to be MV2 and MV3 in that order. |
Because we use
requestDomains
in DNR "allowAllRequests" rules, disabled site domains always include subdomains.Is it important to be able to disable Privacy Badger on site without disabling it on subdomains of that site?
If the answer is no, we should update MV2 Privacy Badger to work the same way, and remove the leading wildcard from the disabled sites domain input placeholder and any documentation. We should also update the validation for the disabled sites input, and remove wildcards from any existing disabled sites.
DNR "allowAllRequests" rules:
privacybadger/src/lib/dnr/utils.js
Lines 445 to 467 in 7d8d051
Content script matching logic that we made to work the same way:
privacybadger/src/lib/dnr/utils.js
Lines 36 to 46 in 7d8d051
The text was updated successfully, but these errors were encountered: