-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kustomise files for daily #256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idlewis Thanks. Looks good. Just want to confirm the purpose of all-namespaces2. Is it to specify a different namespace? Wondering whether changing namespace: default
in all-namespaces/kustomization.yaml would achieve the same
@leochr Yes, the purpose of the all-namespaces2 is to specify a different a namespace, and yes this could be done in all-namespaces. However, the idea was that, because all-namespaces adds in a new resource file (the cluster roles yaml) I was expecting that users would want to treat all-namespaces as a base to build on, and probably would prefer to leave it untouched, rather than having to edit it. So all-namespaces2 is an example of how a user could build on all-namespaces without having to modify it. |
Thanks @idlewis . It'll be good to separate the folders that customers should modify from the folders/files we provide (i.e. move all-namespace2 and test-namespace under Suggest the following names for the folders: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idlewis Thanks for the update. If possible, it'll be good to have the examples directly under daily
folder. This way that's the only folder customers would have to edit and also avoid accidentally modifying other folders directly under overlays.
Maybe you are planning to add, it'll be good to have an example for watch-another-namespace.
@leochr I think I've addressed all the review comments. Hopefully should be ready for review/merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idlewis Looks good. Thanks.
start to deal with #177