Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare repository for tag conversion function signature update #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michaelhtm
Copy link
Member

Description of changes:
The To/FromACKTags function signatures are changing with the
next code-gen release. This PR aims to ensure custom code adapts as well.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and rushmash91 March 13, 2025 04:15
Copy link

ack-prow bot commented Mar 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Mar 13, 2025
@michaelhtm michaelhtm force-pushed the update/acktagsconversion branch 4 times, most recently from b5e6b1d to 76e4912 Compare March 14, 2025 03:00
The To/FromACKTags function signatures are changing with the next
code-gen release. This PR aims to ensure custom code adapts as well.
@michaelhtm michaelhtm force-pushed the update/acktagsconversion branch from 76e4912 to 7f9cc2b Compare March 14, 2025 20:54
Copy link

ack-prow bot commented Mar 14, 2025

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
codeartifact-verify-attribution 7f9cc2b link false /test codeartifact-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant