feature: allow relocating images with relok8s lib #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migmartri
approved these changes
Nov 30, 2021
| klog.Errorf("unable to build %q chart dependencies: %+v", id, err) | ||
| errs = multierror.Append(errs, errors.Trace(err)) | ||
| if s.relocateContainerImages { | ||
| packagedChartPath, err = s.SyncWithRelok8s(ch, outdir) |
There was a problem hiding this comment.
I like how you encapsulated the methods SyncWithRelok8s and SyncWithChartsSyncer :)
| @@ -133,3 +109,90 @@ func (s *Syncer) SyncPendingCharts(names ...string) error { | |||
|
|
|||
| return errors.Trace(errs) | |||
| } | |||
|
|
|||
| func (s *Syncer) SyncWithRelok8s(chart *Chart, outdir string) (string, error) { | |||
There was a problem hiding this comment.
It would be nice to add a comment on top of this method explaining what it does, its requirements and so on
|
|
||
| func (s *Syncer) SyncWithRelok8s(chart *Chart, outdir string) (string, error) { | ||
| outputChartPath := filepath.Join(outdir, "%s-%s.relocated.tgz") | ||
| packagedChartPath := filepath.Join(outdir, fmt.Sprintf("%s-%s.relocated.tgz", chart.Name, chart.Version)) |
There was a problem hiding this comment.
I'd add a TODO comment saying to change it once vmware-tanzu/asset-relocation-tool-for-kubernetes#94 is fixed
| Target: mover.Target{ | ||
| Rules: mover.RewriteRules{ | ||
| Registry: s.target.GetContainerRegistry(), | ||
| RepositoryPrefix: s.target.GetContainerRepository(), |
There was a problem hiding this comment.
You can now add ForcePush if you update to v0.3.45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new feature to charts-syncer.
It is possible to do a full relocation of the chart (including container images) thanks to the integration with the relok8s library.
For that we should only add
relocateContainerImages: trueto our config file. However, in order to relok8s to work properly, it requires that the source chart includes an image hints file. Currently, this file should be called.relok8s-images.yamland should be packaged inside the chart. If this file is not found, the sync for that specific chart will be skipped.If relocateContainerImages is not set or set to false, charts-syncer will continue working as of today. This is, it will sync chart packages (but no container images) if source charts fulfil the documented requirements
Usage: