fix: Prevents setting LoadBalancerIP when AWS-specific annotations are present #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kamaji-documentation canceled.
|
Addresses clastix#688, this commit adds a check to the ControlPlane service's annotations. If the `spec.loadBalancerIP` property is set in the service, the AWS cloud controller will complain and causes issues. The controller now checks for the presence of these specific annotations and avoids setting the LoadBalancerIP to ensure that the service is correctly configured according to AWS requirements.
prometherion
requested changes
Mar 4, 2025
There was a problem hiding this comment.
Of course we'll need to rename the PR and amend commit subject, but this is fine.
| if len(address) > 0 { | ||
|
|
||
| // hack: Load Balancer IP should not be added to avoid the AWS Load Balancer get stuck | ||
| _, hasLbAwsEipAllocations := r.resource.Annotations["service.beta.kubernetes.io/aws-load-balancer-eip-allocations"] |
There was a problem hiding this comment.
We have a better option, here:
The.spec.loadBalancerIP field for a Service was deprecated in Kubernetes v1.24.
source: https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer
Let's remove at all the r.resource.Spec.LoadBalancerIP assignment and we'll be safe.
There was a problem hiding this comment.
Oh, wow, good to know!
I think it might make more sense to close this then and open a new PR
|
Closing in favor of #713 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #688, this commit adds a check to the ControlPlane service's annotations.
If the
spec.loadBalancerIPproperty is set in the service, the AWS cloud controller will complain and causes issues.The controller now checks for the presence of these specific annotations and avoids setting the LoadBalancerIP to ensure that the service is correctly configured according to AWS requirements.