chore(anomaly detection): too many instances of test is run in parallel during deployment, skipping test for now #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Sentry found no issues in your recent changes ✅ |
ram-senth
force-pushed
the
anomaly-detection/flaky-test
branch
from
4384a46 to
bdc87cc
Compare
…el during deployment, skipping test for now
ram-senth
force-pushed
the
anomaly-detection/flaky-test
branch
from
bdc87cc to
21be9ac
Compare
aayush-se
reviewed
Mar 14, 2025
Comment on lines
+538
to
+571
| # TODO: Enable this test once we have a way to run tests in parallel without causing multiple parallel runs | ||
| # def test_detect_anomalies_combo_large_current(self): | ||
| # config = AnomalyDetectionConfig( | ||
| # time_period=15, sensitivity="low", direction="both", expected_seasonality="auto" | ||
| # ) | ||
|
|
||
| # loaded_synthetic_data = convert_synthetic_ts( | ||
| # "tests/seer/anomaly_detection/test_data/synthetic_series", as_ts_datatype=True | ||
| # ) | ||
| # ts_history = loaded_synthetic_data.timeseries[0] | ||
| # last_history_timestamp = ts_history[-1].timestamp | ||
| # last_history_value = ts_history[-1].value | ||
| # n = 700 # should be greater than 7 days * 24 hours * 60 minutes * 15 minutes = 672 | ||
|
|
||
| # # Generate new observation window of n points which are the same as the last point | ||
| # ts_current = [] | ||
| # for j in range(1, n + 1): | ||
| # ts_current.append( | ||
| # TimeSeriesPoint( | ||
| # timestamp=last_history_timestamp + config.time_period * 60 * j, | ||
| # value=last_history_value, | ||
| # ) | ||
| # ) | ||
|
|
||
| # context = TimeSeriesWithHistory(history=ts_history, current=ts_current) | ||
|
|
||
| # request = DetectAnomaliesRequest( | ||
| # organization_id=1, project_id=1, config=config, context=context | ||
| # ) | ||
|
|
||
| # response = AnomalyDetection().detect_anomalies(request=request, time_budget_ms=5000) | ||
|
|
||
| # assert isinstance(response, DetectAnomaliesResponse) | ||
| # assert isinstance(response.timeseries, list) |
There was a problem hiding this comment.
I think you can just pass in a @pytest.mark.skip(reason="<reason>") to mark it rather than commenting it out.
https://stackoverflow.com/questions/38442897/how-do-i-disable-a-test-using-pytest
aayush-se
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like there is some issue with how test parallelization is setup. One test is getting executed 100+ times in parallel and this seems to make the tests run very slow, resulting in a timeout.