Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SR): Add SR to Mobile onboarding features #13034

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kahest
Copy link
Member

@kahest kahest commented Mar 18, 2025

DESCRIBE YOUR PR

🛑 we decided to only merge the Android changes now, will review iOS+RN when new view renderer is default 🛑

Adds SR config snippets to onboarding feature snippets for iOS/RN as applicable (Flutter will follow in 1-2 months):

  • ✅ iOS (Getting Started)
  • iOS (Manual Setup) - descoped, snippets are currently very limited, needs separate overhaul
  • ✅ RN (Getting Started)
  • RN (Manual Setup) - descoped, doesn't touch feature configs

related PR for in-product onboarding: getsentry/sentry#87304

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

Copy link

vercel bot commented Mar 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2025 5:29pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2025 5:29pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2025 5:29pm

Copy link

codecov bot commented Mar 18, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.57MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.43MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.57MB -0.0%
../instrumentation.js -3 bytes 904.32kB -0.0%
9523.js -3 bytes 880.37kB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.16kB -0.0%
static/chunks/3319-*.js -3 bytes 393.41kB -0.0%
static/rs6zDK2weUqyHvFirVoQp/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/rs6zDK2weUqyHvFirVoQp/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/6dPvGgkMgEzgBsC2uobxr/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/6dPvGgkMgEzgBsC2uobxr/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

also fixes missing semicolons in obj-c snippets
@kahest kahest marked this pull request as draft March 19, 2025 17:11
@kahest kahest changed the base branch from master to kahest/android-sr-onboarding March 19, 2025 17:12
@kahest kahest changed the base branch from kahest/android-sr-onboarding to master March 19, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants