feat(SR): Add SR to Mobile project onboarding features #87304
Conversation
switch SR and Profiling so SR is last button, and Tracing+Profiling are next to each other
github-actions
bot
added
the
Scope: Frontend
| @@ -391,18 +403,6 @@ export function ProductSelection({ | |||
| checked={urlProducts.includes(ProductSolution.PERFORMANCE_MONITORING)} | |||
| /> | |||
| )} | |||
| {products.includes(ProductSolution.SESSION_REPLAY) && ( | |||
There was a problem hiding this comment.
this changes the order of the product selection buttons (see PR description why)
- from Tracing - Session Replay - Profiling
- to Tracing - Profiling - Session Replay
we might want to reconsider this, not a strong opinion of mine :)
| // Record Session Replays for 100% of Errors and 10% of Sessions | ||
| options.sessionReplay.onErrorSampleRate = 1.0 | ||
| options.sessionReplay.sessionSampleRate = 0.1 | ||
| // We recommend the ~5x more performant experimental view renderer |
There was a problem hiding this comment.
we need to decide if we want to point this out here. IMO we should, or we postpone this PR for iOS (and RN, see below)
There was a problem hiding this comment.
Make sense to me as well.
| }${ | ||
| params.isReplaySelected | ||
| ? ` | ||
| // Record Session Replays for 10% of Sessions and 100% of Errors |
There was a problem hiding this comment.
RN will have the enableExperimentalViewRenderer option soon (PR in review), same considerations as for iOS (see https://github.com/getsentry/sentry/pull/87304/files#r2001723725) apply
kahest
requested review from
bruno-garcia,
romtsn,
philprime,
krystofwoldrich,
michellewzhang,
jas-kas and
a team
and removed request for
romtsn,
philprime and
krystofwoldrich
| description={t( | ||
| 'Video-like reproductions of user sessions with debugging context to help you confirm issue impact and troubleshoot faster.' | ||
| )} | ||
| docLink="https://docs.sentry.io/platforms/javascript/guides/react/session-replay/" |
There was a problem hiding this comment.
i know the other links are also platform-specific too, but curious why these links are platform-specific and not linking to the general product docs
There was a problem hiding this comment.
good point - IMO makes sense to link to product docs for all of these (in a separate PR?)
kahest
changed the title
Adds SR config snippets to onboarding feature snippets for Android: Android part of #87304 related PR for sentry-docs: getsentry/sentry-docs#13051
…87412) <!-- Describe your PR here. --> - updates order of products in the product selector to: Tracing - Profiling - Session Replay - came up in [this PR](#87304) - relevant for Mobile platforms that have all three now, first of which is [Android](#87408) - changes the links in the product buttons from specific SDK pages to generic product pages - came up in [this PR](#87304 (comment)) - TBD: Tracing links to Key Terms page because there isn't a dedicated single product page 
🛑 we decided to only merge the Android changes now, will review iOS+RN when new view renderer is default 🛑
Adds SR config snippets to onboarding feature snippets for iOS/RN as applicable (Flutter will follow in 1-2 months):
Note: this PR also changes the order of the product selection buttons -> split out into #87412
related PR for sentry-docs: getsentry/sentry-docs#13034
fixes #84250