ref(shared-views): Delete all usages of groupsearchview.position #87320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
markstory
approved these changes
Mar 19, 2025
JoshFerge
approved these changes
Mar 19, 2025
MichaelSun48
force-pushed
the
msun/sharedViews/removeUsagesOfPosition
branch
from
3e26c48 to
5b8a818
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #87320 +/- ##
===========================================
+ Coverage 33.16% 87.74% +54.58%
===========================================
Files 8358 9879 +1521
Lines 466166 560217 +94051
Branches 22076 22075 -1
===========================================
+ Hits 154616 491585 +336969
+ Misses 311146 68228 -242918
Partials 404 404 |
MichaelSun48
force-pushed
the
msun/sharedViews/removeUsagesOfPosition
branch
from
5b8a818 to
9c79406
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Deletes all usages of groupsearchview.position, except for any usages in migration tests.
I global searches for
GroupSearchView.andpositionin all .py files and hand checked to make sure we were not using it anywhere.