ref(shared-views): Delete all usages of groupsearchview.position

src/sentry/api/endpoints/organization_pinned_searches.py

@@ -59,7 +59,6 @@ def put(self, request: Request, organization) -> Response:
         default_view, created = GroupSearchView.objects.create_or_update(
             organization=organization,
             user_id=request.user.id,
-            position=0,
             values={
                 "name": "Default Search",
                 "query": result["query"],

src/sentry/issues/endpoints/organization_group_search_views.py

@@ -263,7 +263,6 @@ def _update_existing_view(
         gsv.name = view["name"]
         gsv.query = view["query"]
         gsv.query_sort = view["querySort"]
-        gsv.position = position
         gsv.is_all_projects = view.get("isAllProjects", False)
 
         if "projects" in view:
@@ -300,7 +299,6 @@ def _create_view(
         name=view["name"],
         query=view["query"],
         query_sort=view["querySort"],
-        position=position,
         is_all_projects=view.get("isAllProjects", False),
         environments=view.get("environments", []),
         time_filters=view.get("timeFilters", {"period": "14d"}),

src/sentry/models/groupsearchview.py

@@ -85,7 +85,3 @@ class Meta:
                 deferrable=models.Deferrable.DEFERRED,
             )
         ]
-
-    @property
-    def is_default(self):
-        return self.position == 0

src/sentry/testutils/helpers/backups.py

@@ -628,7 +628,6 @@ def create_exhaustive_organization(
             organization=org,
             query=f"some query for {slug}",
             query_sort="date",
-            position=0,
         )
         GroupSearchViewProject.objects.create(
             group_search_view=group_search_view,

tests/sentry/api/endpoints/test_organization_pinned_searches.py

@@ -44,7 +44,6 @@ def test(self):
             user_id=self.member.id,
             query=query,
             query_sort=sort,
-            position=0,
         )
         assert GroupSearchViewStarred.objects.filter(
             organization=self.organization,

tests/sentry/deletions/test_organizationmember.py

@@ -16,7 +16,6 @@ def test_simple(self):
             name="Custom View",
             query="is:unresolved",
             query_sort="date",
-            position=0,
         )
 
         self.ScheduledDeletion.schedule(instance=member, days=0)
@@ -41,7 +40,6 @@ def test_only_org_specific_views_deleted(self):
             name="Custom View",
             query="is:unresolved",
             query_sort="date",
-            position=0,
         )
 
         custom_view_two = GroupSearchView.objects.create(
@@ -50,7 +48,6 @@ def test_only_org_specific_views_deleted(self):
             name="Custom View",
             query="is:unresolved",
             query_sort="date",
-            position=0,
         )
 
         self.ScheduledDeletion.schedule(instance=member_one, days=0)

tests/sentry/issues/endpoints/test_organization_group_index.py

@@ -2377,7 +2377,6 @@ def test_user_default_custom_view_query(self, _: MagicMock) -> None:
         default_view = GroupSearchView.objects.create(
             organization=self.organization,
             user_id=self.user.id,
-            position=0,
             name="Default View",
             query="ZeroDivisionError",
             query_sort="date",
@@ -2422,7 +2421,6 @@ def test_non_default_custom_view_query(self, _: MagicMock) -> None:
         GroupSearchView.objects.create(
             organization=self.organization,
             user_id=self.user.id,
-            position=0,
             name="Default View",
             query="TypeError",
             query_sort="date",
@@ -2431,7 +2429,6 @@ def test_non_default_custom_view_query(self, _: MagicMock) -> None:
         view = GroupSearchView.objects.create(
             organization=self.organization,
             user_id=self.user.id,
-            position=1,
             name="Custom View",
             query="ZeroDivisionError",
             query_sort="date",

tests/sentry/issues/endpoints/test_organization_group_search_views.py

@@ -43,7 +43,6 @@ def create_base_data(self) -> dict[str, list[GroupSearchView]]:
             user_id=user_1.id,
             query="is:unresolved",
             query_sort="date",
-            position=0,
         )
         GroupSearchViewStarred.objects.create(
             organization=self.organization,
@@ -59,7 +58,6 @@ def create_base_data(self) -> dict[str, list[GroupSearchView]]:
             user_id=user_1.id,
             query="is:ignored",
             query_sort="freq",
-            position=2,
         )
         GroupSearchViewStarred.objects.create(
             organization=self.organization,
@@ -74,7 +72,6 @@ def create_base_data(self) -> dict[str, list[GroupSearchView]]:
             user_id=user_1.id,
             query="is:resolved",
             query_sort="new",
-            position=1,
         )
         GroupSearchViewStarred.objects.create(
             organization=self.organization,
@@ -89,7 +86,6 @@ def create_base_data(self) -> dict[str, list[GroupSearchView]]:
             user_id=self.user_2.id,
             query="is:unresolved",
             query_sort="date",
-            position=0,
         )
         GroupSearchViewStarred.objects.create(
             organization=self.organization,
@@ -104,7 +100,6 @@ def create_base_data(self) -> dict[str, list[GroupSearchView]]:
             user_id=self.user_2.id,
             query="is:resolved",
             query_sort="new",
-            position=1,
         )
         GroupSearchViewStarred.objects.create(
             organization=self.organization,
@@ -500,7 +495,6 @@ def create_base_data_with_page_filters(self) -> list[GroupSearchView]:
             user_id=user_1.id,
             query="is:unresolved",
             query_sort="date",
-            position=0,
             time_filters={"period": "14d"},
             environments=[],
         )
@@ -518,7 +512,6 @@ def create_base_data_with_page_filters(self) -> list[GroupSearchView]:
             user_id=user_1.id,
             query="is:resolved",
             query_sort="new",
-            position=1,
             time_filters={"period": "7d"},
             environments=["staging", "production"],
         )
@@ -536,7 +529,6 @@ def create_base_data_with_page_filters(self) -> list[GroupSearchView]:
             user_id=user_1.id,
             query="is:ignored",
             query_sort="freq",
-            position=2,
             time_filters={"period": "30d"},
             environments=["development"],
         )
@@ -709,7 +701,6 @@ def test_invalid_project_ids(self) -> None:
             user_id=self.user.id,
             query="is:unresolved",
             query_sort="date",
-            position=0,
             time_filters={"period": "14d"},
             environments=["production"],
         )
@@ -777,7 +768,6 @@ def create_base_data_with_page_filters(self) -> None:
             user_id=user_1.id,
             query="is:unresolved",
             query_sort="date",
-            position=0,
             is_all_projects=False,
             time_filters={"period": "14d"},
             environments=[],
@@ -796,7 +786,6 @@ def create_base_data_with_page_filters(self) -> None:
             user_id=user_1.id,
             query="is:resolved",
             query_sort="new",
-            position=1,
             is_all_projects=False,
             time_filters={"period": "7d"},
             environments=["staging", "production"],
@@ -815,7 +804,6 @@ def create_base_data_with_page_filters(self) -> None:
             user_id=user_1.id,
             query="is:ignored",
             query_sort="freq",
-            position=2,
             is_all_projects=True,
             time_filters={"period": "30d"},
             environments=["development"],
@@ -834,7 +822,6 @@ def create_base_data_with_page_filters(self) -> None:
             user_id=self.user_2.id,
             query="is:unresolved",
             query_sort="date",
-            position=0,
             is_all_projects=False,
             time_filters={"period": "14d"},
             environments=[],
@@ -853,7 +840,6 @@ def create_base_data_with_page_filters(self) -> None:
             user_id=self.user_4.id,
             query="is:unresolved",
             query_sort="date",
-            position=0,
             is_all_projects=False,
             time_filters={"period": "14d"},
             environments=[],

tests/sentry/models/test_groupsearchview.py

@@ -13,7 +13,6 @@ def test_create_views(self):
             organization=org,
             query="some query",
             query_sort="date",
-            position=0,
         )
 
         GroupSearchView.objects.create(
@@ -22,9 +21,6 @@ def test_create_views(self):
             organization=org,
             query="some query #2",
             query_sort="date",
-            position=1,
         )
 
         assert GroupSearchView.objects.filter(user_id=user.id).count() == 2
-        assert GroupSearchView.objects.filter(user_id=user.id, position=0).count() == 1
-        assert GroupSearchView.objects.filter(user_id=user.id, position=1).count() == 1