Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(issue-details): Update streamline util to better support enforcing new experience #87336

Merged
merged 6 commits into from
Mar 20, 2025

Conversation

roggenkemper
Copy link
Member

we previously defaulted to "false" in the backend, but that doesn't allow us to properly show the experience to users with the "enforced" flag. now, we will be able to see if a user has the option defined or not, and show them the correct experience based off that.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 18, 2025
Copy link

codecov bot commented Mar 18, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
9975 2 9973 5
View the top 2 failed test(s) by shortest run time
useHasStreamlinedUI ignores preferences if enforce flag is set and user has not opted out
Stack Traces | 0.013s run time
Error: expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false
    at Object.<anonymous> (.../views/issueDetails/utils.spec.tsx:97:28)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)
GroupEventAttachments filters by date/query when using Streamlined UI
Stack Traces | 0.074s run time
Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)

Expected: ".../issues/group-id/attachments/", ObjectContaining {"query": {"environment": ["staging"], "query": "user.email:[email protected]", "statsPeriod": "3d"}}
Received: ".../issues/group-id/attachments/", {"data": undefined, "error": [Function error], "headers": undefined, "host": undefined, "method": "GET", "query": {"statsPeriod": "3d"}, "success": [Function success]}

Number of calls: 1
    at Object.<anonymous> (.../issueDetails/groupEventAttachments/groupEventAttachments.spec.tsx:191:32)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at processTimers (node:internal/timers:526:9)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

roggenkemper added a commit that referenced this pull request Mar 19, 2025
…7337)

with #87336 will allow us to
start opting users into the new experience. Returns `None` instead of
False so that the frontend can determine if we show the new UI or not
@roggenkemper roggenkemper merged commit a247a21 into master Mar 20, 2025
41 checks passed
@roggenkemper roggenkemper deleted the roggenkemper/updatestreamlinedutil branch March 20, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants