Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(grouping): Small enhancements refactors #87366

Merged
merged 11 commits into from
Mar 20, 2025

Conversation

lobsterkatie
Copy link
Member

This PR includes a few small refactors to enhancements code to either simplify logic or make the code easier to understand. No behavior changes.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 18, 2025
Base automatically changed from kmclb-various-enhancement-clarifications to master March 19, 2025 19:43
@lobsterkatie lobsterkatie force-pushed the kmclb-small-enhancement-simplifications branch from 49bf1f3 to cb18d48 Compare March 19, 2025 20:29
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/grouping/enhancer/rules.py 0.00% 3 Missing ⚠️
src/sentry/grouping/enhancer/actions.py 60.00% 2 Missing ⚠️
src/sentry/grouping/enhancer/matchers.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #87366      +/-   ##
==========================================
+ Coverage   87.53%   87.74%   +0.20%     
==========================================
  Files        9880     9880              
  Lines      560251   560269      +18     
  Branches    22076    22076              
==========================================
+ Hits       490442   491634    +1192     
+ Misses      69405    68231    -1174     
  Partials      404      404              

@lobsterkatie lobsterkatie force-pushed the kmclb-small-enhancement-simplifications branch from cb18d48 to a3e3a19 Compare March 19, 2025 21:23
@lobsterkatie lobsterkatie marked this pull request as ready for review March 20, 2025 18:15
@lobsterkatie lobsterkatie requested a review from a team as a code owner March 20, 2025 18:15
@lobsterkatie lobsterkatie merged commit bbb8842 into master Mar 20, 2025
48 checks passed
@lobsterkatie lobsterkatie deleted the kmclb-small-enhancement-simplifications branch March 20, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants