-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(grouping): Small enhancements refactors #87366
Merged
lobsterkatie
merged 11 commits into
master
from
kmclb-small-enhancement-simplifications
Mar 20, 2025
Merged
ref(grouping): Small enhancements refactors #87366
lobsterkatie
merged 11 commits into
master
from
kmclb-small-enhancement-simplifications
Mar 20, 2025
+26
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armenzg
approved these changes
Mar 19, 2025
Base automatically changed from
kmclb-various-enhancement-clarifications
to
master
March 19, 2025 19:43
49bf1f3
to
cb18d48
Compare
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #87366 +/- ##
==========================================
+ Coverage 87.53% 87.74% +0.20%
==========================================
Files 9880 9880
Lines 560251 560269 +18
Branches 22076 22076
==========================================
+ Hits 490442 491634 +1192
+ Misses 69405 68231 -1174
Partials 404 404 |
cb18d48
to
a3e3a19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a few small refactors to enhancements code to either simplify logic or make the code easier to understand. No behavior changes.