ref(grouping): Do preliminary typing work for enhancements #87369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #87369 +/- ##
==========================================
- Coverage 87.74% 87.74% -0.01%
==========================================
Files 9897 9897
Lines 561320 561331 +11
Branches 22149 22149
==========================================
+ Hits 492508 492515 +7
- Misses 68408 68412 +4
Partials 404 404 |
armenzg
approved these changes
Mar 19, 2025
lobsterkatie
force-pushed
the
kmclb-small-enhancement-simplifications
branch
from
49bf1f3 to
cb18d48
Compare
lobsterkatie
force-pushed
the
kmclb-enhancement-types-prework
branch
from
2760276 to
4eb7eb8
Compare
lobsterkatie
force-pushed
the
kmclb-small-enhancement-simplifications
branch
from
cb18d48 to
a3e3a19
Compare
lobsterkatie
force-pushed
the
kmclb-enhancement-types-prework
branch
from
4eb7eb8 to
0c66767
Compare
Base automatically changed from
kmclb-small-enhancement-simplifications
to
master
March 20, 2025 18:15
lobsterkatie
force-pushed
the
kmclb-enhancement-types-prework
branch
from
0c66767 to
94395bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step towards adding types to the enhancements code, this makes a handful of code changes which will be necessary once types are added to all of the enhancements methods, which will happen in #87370. (I split it up this way so that hopefully it will be a little easier to review.)