Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernelctf: add CVE-2023-4015_lts_2 #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kungfulon
Copy link
Contributor

No description provided.

@kungfulon kungfulon force-pushed the exp68 branch 4 times, most recently from be09847 to 25480eb Compare November 30, 2024 14:33
@koczkatamas koczkatamas force-pushed the master branch 3 times, most recently from 933028d to c111d81 Compare March 3, 2025 14:31
@koczkatamas koczkatamas force-pushed the master branch 13 times, most recently from 76d6b57 to bf0d68f Compare March 13, 2025 15:39
Copy link
Collaborator

@koczkatamas koczkatamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

This is just a quick code quality review. We're planning to review the submissions more deeply (actually understanding what the exploit does) in two weeks.

In general, the code quality looks good, no major concerns. I've left a few smaller comments in #140, please apply them here as well.

We also have a draft style guide now. Please take a look and let us know if it's helpful for understanding our code quality expectations: https://google.github.io/security-research/kernelctf/style_guide.

Thanks for the submission and PR!

@koczkatamas
Copy link
Collaborator

In general, the code quality looks good, no major concerns. I've left a few smaller comments in #140, please apply them here as well.

Originally I mentioned a wrong PR, I've meant PR #140.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants