Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kernelCTF CVE-2024-0582_mitigation #151

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add kernelCTF CVE-2024-0582_mitigation #151

wants to merge 6 commits into from

Conversation

nightuhu
Copy link

@nightuhu nightuhu commented Jan 7, 2025

No description provided.

@google-cla Google CLA
Copy link

google-cla bot commented Jan 7, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

matrizzo added a commit that referenced this pull request Jan 7, 2025
@matrizzo
kernelCTF: fix check-submission.py for v2 flags
44f5c2c 
In 57ace30 we introduced a new flag
format but forgot to update the flag regex in check-submission.py so now
it's rejecting valid submisisons that use the new format (e.g.
#151).
@matrizzo matrizzo mentioned this pull request Jan 7, 2025
Merged
koczkatamas pushed a commit that referenced this pull request Jan 8, 2025
@matrizzo
kernelCTF: fix check-submission.py for v2 flags (#152)
4fa10b5 
In 57ace30 we introduced a new flag
format but forgot to update the flag regex in check-submission.py so now
it's rejecting valid submisisons that use the new format (e.g.
#151).
@nightuhu nightuhu closed this Jan 8, 2025
@nightuhu nightuhu reopened this Jan 9, 2025
@koczkatamas koczkatamas force-pushed the master branch 3 times, most recently from 933028d to c111d81 Compare March 3, 2025 14:31
@koczkatamas koczkatamas force-pushed the master branch 13 times, most recently from 76d6b57 to bf0d68f Compare March 13, 2025 15:39
koczkatamas
koczkatamas reviewed Mar 14, 2025
View reviewed changes
Copy link
Collaborator

@koczkatamas koczkatamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

This is just a quick code quality review. We're planning to review the submissions more deeply (actually understanding what the exploit does) in two weeks.

In general, the code quality looks good!

This exploit is relatively straightforward, if you are planning to submit more complicated ones in the future, then FYI we have a (still draft) style guide now, in case it becomes helpful: https://google.github.io/security-research/kernelctf/style_guide.

Thanks for the submission and PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koczkatamas koczkatamas koczkatamas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nightuhu @koczkatamas