Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3974. TabView steals keypresses from active ContextMenu #3995

Merged
merged 3 commits into from
Mar 21, 2025

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Mar 18, 2025

Fixes

Proposed Changes/Todos

  • Add TabView KeyBindings for CursorUp and Cursor Down

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

Sorry, something went wrong.

@tznind
Copy link
Collaborator

tznind commented Mar 19, 2025

@tig is it possible to please prioritise getting this reviewed, it is the last blocker bug on getting next TGD edition out.

❤️

See gui-cs/TerminalGuiDesigner#307

@tznind tznind requested a review from tig March 20, 2025 20:34
@tig tig merged commit 8b5639e into gui-cs:v2_develop Mar 21, 2025
11 checks passed
@BDisp BDisp deleted the v2_3974_tavview-steals-keys-fix branch March 21, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TabView steals keypresses from active ContextMenu
3 participants